All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: 'Markus Elfring' <Markus.Elfring@web.de>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	"'Christoph Hellwig'" <hch@lst.de>,
	"'Daniel Wagner'" <dwagner@suse.de>,
	"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
	"'Nikolay Borisov'" <nborisov@suse.com>,
	"'Sungjong Seo'" <sj1557.seo@samsung.com>,
	"'Valdis Klētnieks'" <valdis.kletnieks@vt.edu>,
	linkinjeon@gmail.com, linux-fsdevel@vger.kernel.org
Subject: RE: [PATCH v4 10/13] exfat: add nls operations
Date: Thu, 21 Nov 2019 08:19:30 +0000	[thread overview]
Message-ID: <000f01d5a044$65ff7b40$31fe71c0$@samsung.com> (raw)
In-Reply-To: <df089831-038c-3b39-6ec7-684d1f698756@web.de>

> > +	exfat_msg(sb, KERN_ERR,
> > +			"failed to load upcase table (idx : 0x%08x, chksum :
> 0x%08x, utbl_chksum : 0x%08x)\n",
> > +			index, checksum, utbl_checksum);
> > +
> > +	ret = -EINVAL;
> 
> Can a blank line be omitted between the message and the error code?
Okay.
> 
> 
> > +release_bh:
> > +	brelse(bh);
> > +	exfat_free_upcase_table(sb);
> > +	return ret;
> > +}
> 
> I got the impression that the resource management is still questionable
> for this function implementation.
> 
> 1. Now I suggest to move the call of the function “brelse” to the end
>    of the while loop. The label “release_bh” would be renamed to “free_table”
> then.
Okay.
> 
> 2. Can a variable initialisation be converted to the assignment “ret = -EIO;”
>    in an if branch?
Okay, Will fix it on v5.

Thanks for your review!
> 
> Regards,
> Markus

WARNING: multiple messages have this Message-ID (diff)
From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Markus Elfring'" <Markus.Elfring@web.de>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	"'Christoph Hellwig'" <hch@lst.de>,
	"'Daniel Wagner'" <dwagner@suse.de>,
	"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
	"'Nikolay Borisov'" <nborisov@suse.com>,
	"'Sungjong Seo'" <sj1557.seo@samsung.com>,
	"'Valdis Klētnieks'" <valdis.kletnieks@vt.edu>,
	linkinjeon@gmail.com, linux-fsdevel@vger.kernel.org
Subject: RE: [PATCH v4 10/13] exfat: add nls operations
Date: Thu, 21 Nov 2019 17:19:30 +0900	[thread overview]
Message-ID: <000f01d5a044$65ff7b40$31fe71c0$@samsung.com> (raw)
In-Reply-To: <df089831-038c-3b39-6ec7-684d1f698756@web.de>

> > +	exfat_msg(sb, KERN_ERR,
> > +			"failed to load upcase table (idx : 0x%08x, chksum :
> 0x%08x, utbl_chksum : 0x%08x)\n",
> > +			index, checksum, utbl_checksum);
> > +
> > +	ret = -EINVAL;
> 
> Can a blank line be omitted between the message and the error code?
Okay.
> 
> 
> > +release_bh:
> > +	brelse(bh);
> > +	exfat_free_upcase_table(sb);
> > +	return ret;
> > +}
> 
> I got the impression that the resource management is still questionable
> for this function implementation.
> 
> 1. Now I suggest to move the call of the function “brelse” to the end
>    of the while loop. The label “release_bh” would be renamed to “free_table”
> then.
Okay.
> 
> 2. Can a variable initialisation be converted to the assignment “ret = -EIO;”
>    in an if branch?
Okay, Will fix it on v5.

Thanks for your review!
> 
> Regards,
> Markus



  reply	other threads:[~2019-11-21  8:19 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20191121052913epcas1p1b28d2727dca5df42a6f2b8eb6b6dbcbb@epcas1p1.samsung.com>
2019-11-21  5:26 ` [PATCH v4 00/13] add the latest exfat driver Namjae Jeon
2019-11-21  5:26   ` [PATCH v4 01/13] exfat: add in-memory and on-disk structures and headers Namjae Jeon
2019-11-21  5:26   ` [PATCH v4 02/13] exfat: add super block operations Namjae Jeon
2019-11-21  9:40     ` Markus Elfring
2019-11-21  9:40       ` Markus Elfring
2019-11-21  5:26   ` [PATCH v4 03/13] exfat: add inode operations Namjae Jeon
2019-11-21 10:40     ` Markus Elfring
2019-11-21 10:40       ` Markus Elfring
2019-11-21 11:51       ` Greg Kroah-Hartman
2019-11-21 11:51         ` Greg Kroah-Hartman
2019-11-22  6:33       ` Christoph Hellwig
2019-11-22  6:33         ` Christoph Hellwig
2019-11-21  5:26   ` [PATCH v4 04/13] exfat: add directory operations Namjae Jeon
2019-11-21 13:07     ` Markus Elfring
2019-11-21 13:07       ` Markus Elfring
2019-11-22  3:00       ` Namjae Jeon
2019-11-22  3:00         ` Namjae Jeon
2019-11-22  8:11         ` Markus Elfring
2019-11-22  8:11           ` Markus Elfring
2019-11-22  8:21           ` Namjae Jeon
2019-11-22  8:21             ` Namjae Jeon
2019-11-22  8:34             ` Dan Carpenter
2019-11-22  8:34               ` Dan Carpenter
2019-11-22  8:52           ` Christoph Hellwig
2019-11-22  8:52             ` Christoph Hellwig
2019-11-22 10:30             ` [v4 " Markus Elfring
2019-11-21  5:26   ` [PATCH v4 05/13] exfat: add file operations Namjae Jeon
2019-11-21 13:45     ` Markus Elfring
2019-11-21 13:45       ` Markus Elfring
2019-11-21  5:26   ` [PATCH v4 06/13] exfat: add exfat entry operations Namjae Jeon
2019-11-21 14:10     ` Markus Elfring
2019-11-21 14:10       ` Markus Elfring
2019-11-21  5:26   ` [PATCH v4 07/13] exfat: add bitmap operations Namjae Jeon
2019-11-21  5:26   ` [PATCH v4 08/13] exfat: add exfat cache Namjae Jeon
2019-11-21  5:26   ` [PATCH v4 09/13] exfat: add misc operations Namjae Jeon
2019-11-21  5:26   ` [PATCH v4 10/13] exfat: add nls operations Namjae Jeon
2019-11-21  8:09     ` Markus Elfring
2019-11-21  8:09       ` Markus Elfring
2019-11-21  8:19       ` Namjae Jeon [this message]
2019-11-21  8:19         ` Namjae Jeon
2019-11-21  5:26   ` [PATCH v4 11/13] exfat: add Kconfig and Makefile Namjae Jeon
2019-11-21  5:26   ` [PATCH v4 12/13] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
2019-11-23 15:52     ` kbuild test robot
2019-11-23 15:52       ` kbuild test robot
2019-11-23 15:52     ` [PATCH] exfat: fix boolreturn.cocci warnings kbuild test robot
2019-11-23 15:52       ` kbuild test robot
2019-11-24  2:09       ` Signed-off-by: (was " Valdis Klētnieks
2019-11-24  6:59         ` Greg KH
2019-11-24  6:59           ` Greg KH
2019-11-21  5:26   ` [PATCH v4 13/13] MAINTAINERS: add exfat filesystem Namjae Jeon
2019-11-21  8:55   ` [PATCH v4 00/13] add the latest exfat driver Markus Elfring
2019-11-21  8:55     ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000f01d5a044$65ff7b40$31fe71c0$@samsung.com' \
    --to=namjae.jeon@samsung.com \
    --cc=Markus.Elfring@web.de \
    --cc=dwagner@suse.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linkinjeon@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nborisov@suse.com \
    --cc=sj1557.seo@samsung.com \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.