diff for duplicates of <000f01d5a044$65ff7b40$31fe71c0$@samsung.com> diff --git a/a/1.txt b/N1/1.txt index 1f7eaa5..1e45880 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -18,16 +18,16 @@ Okay. > I got the impression that the resource management is still questionable > for this function implementation. > -> 1. Now I suggest to move the call of the function “brelse” to the end -> of the while loop. The label “release_bh” would be renamed to “free_table” -> then. -Okay. -> -> 2. Can a variable initialisation be converted to the assignment “ret = -EIO;” -> in an if branch? -Okay, Will fix it on v5. - -Thanks for your review! -> -> Regards, +> 1. Now I suggest to move the call of the function “brelse” to the end\r +> of the while loop. The label “release_bh” would be renamed to “free_table”\r +> then.\r +Okay.\r +> \r +> 2. Can a variable initialisation be converted to the assignment “ret = -EIO;”\r +> in an if branch?\r +Okay, Will fix it on v5.\r +\r +Thanks for your review!\r +> \r +> Regards,\r > Markus diff --git a/a/content_digest b/N1/content_digest index 3009c23..110ca08 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\0df089831-038c-3b39-6ec7-684d1f698756@web.de\0" "From\0Namjae Jeon <namjae.jeon@samsung.com>\0" "Subject\0RE: [PATCH v4 10/13] exfat: add nls operations\0" - "Date\0Thu, 21 Nov 2019 08:19:30 +0000\0" + "Date\0Thu, 21 Nov 2019 17:19:30 +0900\0" "To\0'Markus Elfring' <Markus.Elfring@web.de>\0" "Cc\0linux-kernel@vger.kernel.org" kernel-janitors@vger.kernel.org @@ -38,18 +38,18 @@ "> I got the impression that the resource management is still questionable\n" "> for this function implementation.\n" "> \n" - "> 1. Now I suggest to move the call of the function \342\200\234brelse\342\200\235 to the end\n" - "> of the while loop. The label \342\200\234release_bh\342\200\235 would be renamed to \342\200\234free_table\342\200\235\n" - "> then.\n" - "Okay.\n" - "> \n" - "> 2. Can a variable initialisation be converted to the assignment \342\200\234ret = -EIO;\342\200\235\n" - "> in an if branch?\n" - "Okay, Will fix it on v5.\n" - "\n" - "Thanks for your review!\n" - "> \n" - "> Regards,\n" + "> 1. Now I suggest to move the call of the function \342\200\234brelse\342\200\235 to the end\r\n" + "> of the while loop. The label \342\200\234release_bh\342\200\235 would be renamed to \342\200\234free_table\342\200\235\r\n" + "> then.\r\n" + "Okay.\r\n" + "> \r\n" + "> 2. Can a variable initialisation be converted to the assignment \342\200\234ret = -EIO;\342\200\235\r\n" + "> in an if branch?\r\n" + "Okay, Will fix it on v5.\r\n" + "\r\n" + "Thanks for your review!\r\n" + "> \r\n" + "> Regards,\r\n" > Markus -b709d04ced864a43237dcd0cdbb4d05c5fbc835f1967dfd89e16c3df39216ec9 +02d5bf5425af06d00995a5464a109240eb3800101de9441a69f675ca7987ba37
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.