All of lore.kernel.org
 help / color / mirror / Atom feed
From: <ansuelsmth@gmail.com>
To: "'Greg KH'" <gregkh@linuxfoundation.org>
Cc: <mathias.nyman@intel.com>, <linux-usb@vger.kernel.org>
Subject: [PATCH] usb: host: fix implicit declaration error
Date: Sun, 19 Jan 2020 14:19:45 +0100	[thread overview]
Message-ID: <000f01d5cecb$1ead1440$5c073cc0$@gmail.com> (raw)
In-Reply-To: <20200119125315.GA149506@kroah.com>

> On Sun, Jan 19, 2020 at 12:58:28AM +0100, Ansuel Smith wrote:
> > If USB_PCI is not enabled, this error is triggered.
> > drivers/usb/host/ehci-pci.c:152:7:
> > error: implicit declaration of function 'usb_amd_quirk_pll_check';
> >   152 |   if (usb_amd_quirk_pll_check())
> >       |       ^~~~~~~~~~~~~~~~~~~~~~~
> >       |       usb_amd_quirk_pll_enable
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> 
> Is this a new issue?  What commit caused this problem?
> 
> thanks,
> 
> greg k-h

Looks like this is caused by 4fbb8aa75836c3361987f431d9451aecc1830bdd
and ad93562bdeecdded7d02eaaaf1aa5705ab57b1b7.
Looks like it was never added to the header file else condition.


  reply	other threads:[~2020-01-19 13:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-18 23:58 [PATCH] usb: host: fix implicit declaration error Ansuel Smith
2020-01-19 12:53 ` Greg KH
2020-01-19 13:19   ` ansuelsmth [this message]
2020-01-22  7:01     ` 'Greg KH'
2020-01-19 15:45 ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000f01d5cecb$1ead1440$5c073cc0$@gmail.com' \
    --to=ansuelsmth@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.