From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA39EC47258 for ; Fri, 12 Jan 2024 17:22:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8E199DFA; Fri, 12 Jan 2024 18:22:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8E199DFA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1705080161; bh=PDK1xwSqSIeS2CzJXOvaNbp3mToGGxqLZsR5rVTm5IA=; h=From:To:CC:References:In-Reply-To:Subject:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=iFn1L0N7zkkmZ8iShobWZ4soZzTxSYNyWycHvW+I3QzKESaapx1+so3WMXvKCNiC9 H69gmuJB/P9bXYFPFTxKDAlFDF8xkxz8dNMLJnN/MflvcMrNsaxInmGjsnbAvwK9/o gs8f9bcS9614Sn/1JhoHqce860x1/8g2dXLKhAVg= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 39037F80580; Fri, 12 Jan 2024 18:22:09 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E9C4BF80589; Fri, 12 Jan 2024 18:22:08 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7E374F80254; Fri, 12 Jan 2024 18:22:04 +0100 (CET) Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 09811F8003A for ; Fri, 12 Jan 2024 18:22:00 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 09811F8003A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=cirrus.com header.i=@cirrus.com header.a=rsa-sha256 header.s=PODMain02222019 header.b=OR0GINHd Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40C6eAW6010272; Fri, 12 Jan 2024 11:21:58 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-type:content-transfer-encoding; s= PODMain02222019; bh=J3TCSGRnd9DnWnfS+rOSPwl8wXTlbWxJiNR59khbceE=; b= OR0GINHd39SEt59Nux2WoWKhWSASQ9jvB27t7sO+ysdwQJu7DsyFMP0HPdaNmyDF X1WEaldKQSjgjTR1VB2oklM1bG2GrxD7zhSZxuSRQP+8u/4ie4HIIxuvWq/+BhF8 C+kARahk1gR0x0ygxaChAhfeY5pLnf22bcMNVqmHsiBqidUbYKzQYPe8YXuGsNz3 CJwjhcghGzE/xR2hc1zR0aBf15J+9ba1IZsof94jtOPTvZ0MgnkAw6PuV3jm8Ddu n4pF/t2lii8P2HdHIvdDzkjgX1plFVGpAkSvHZJE079Nnt3TWh35NqWZRhcpYMG0 kgGN6tlxlQaJurPTRgOx7g== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vf45prnsr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Jan 2024 11:21:58 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 12 Jan 2024 17:21:57 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.40 via Frontend Transport; Fri, 12 Jan 2024 17:21:57 +0000 Received: from LONN2DGDQ73 (LONN2DGDQ73.ad.cirrus.com [198.61.65.232]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id D3E2515A0; Fri, 12 Jan 2024 17:21:56 +0000 (UTC) From: Stefan Binding To: 'Kenzo Gomez' CC: 'James Schulman' , 'David Rhodes' , 'Richard Fitzgerald' , 'Jaroslav Kysela' , 'Takashi Iwai' , , , , References: <20240112163239.59743-1-kenzo.sgomez@gmail.com> In-Reply-To: <20240112163239.59743-1-kenzo.sgomez@gmail.com> Subject: RE: [PATCH] ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA Date: Fri, 12 Jan 2024 17:21:56 +0000 Message-ID: <000f01da457b$d8268cf0$8873a6d0$@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQNavMYHpNy3oxQTxP/3AG71Wvly+63VfWQQ Content-Language: en-gb X-Proofpoint-GUID: dVLmaUESpk4yggWR00XD8W0QL271qo47 X-Proofpoint-ORIG-GUID: dVLmaUESpk4yggWR00XD8W0QL271qo47 X-Proofpoint-Spam-Reason: safe Message-ID-Hash: ZHNNH3QAGC3SH7SJYMHD5LCNGLKVHYM4 X-Message-ID-Hash: ZHNNH3QAGC3SH7SJYMHD5LCNGLKVHYM4 X-MailFrom: prvs=87412ecd2e=sbinding@opensource.cirrus.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, > -----Original Message----- > From: Kenzo Gomez > Sent: Friday, January 12, 2024 4:32 PM > To: sbinding@opensource.cirrus.com > Cc: Kenzo Gomez ; James Schulman > ; David Rhodes > ; Richard Fitzgerald > ; Jaroslav Kysela ; Takashi > Iwai ; alsa-devel@alsa-project.org; > patches@opensource.cirrus.com; linux-sound@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH] ALSA: hda: cs35l41: Support additional ASUS Zenbook > UX3402VA > > Add new model entry into configuration table. > > Signed-off-by: Kenzo Gomez > --- > sound/pci/hda/cs35l41_hda_property.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/hda/cs35l41_hda_property.c > b/sound/pci/hda/cs35l41_hda_property.c > index c1afb721b4c6..adfb31a6bf1e 100644 > --- a/sound/pci/hda/cs35l41_hda_property.c > +++ b/sound/pci/hda/cs35l41_hda_property.c > @@ -67,6 +67,7 @@ static const struct cs35l41_config > cs35l41_config_table[] = { > { "10431D1F", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, > { "10431DA2", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 1, 2, 0, 0, 0, 0 }, > { "10431E02", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 1, 2, 0, 0, 0, 0 }, > + { "104316A3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 1, 2, 0, 0, 0, 0 }, This entry looks correct, but this table is supposed to be sorted by SSID, can you move the entry to its correct location? > { "10431EE2", I2C, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 0, -1, -1, 0, 0, 0 }, > { "10431F12", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, > { "10431F1F", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, > 0, 0 }, 1, -1, 0, 0, 0, 0 }, > @@ -371,6 +372,7 @@ static const struct cs35l41_prop_model > cs35l41_prop_model_table[] = { > { "CSC3551", "10431D1F", generic_dsd_config }, > { "CSC3551", "10431DA2", generic_dsd_config }, > { "CSC3551", "10431E02", generic_dsd_config }, > + { "CSC3551", "104316A3", generic_dsd_config }, Same with this table, it should be sorted by SSID. > { "CSC3551", "10431EE2", generic_dsd_config }, > { "CSC3551", "10431F12", generic_dsd_config }, > { "CSC3551", "10431F1F", generic_dsd_config }, > -- > 2.43.0 > Thanks, Stefan