Re: [parisc-linux] The new PS/2 Keyboard Driver

[Helge Deller <deller@gmx.de>]

On Thursday 26 October 2000 22:05, Thomas Marteau wrote:

> > 
> Hello everyone,
> 
> We've just updated the PS/2 keyboard driver. The leds and interrupt
> functions work really well on a 712 workstation and also B132 now. The
> updated driver files are available on our website. It works better than
> under HP UX for the B 132 ;->
> 
> http://www.esiee.fr/~djoudim
> 
> The ESIEE Port Team in Paris.
> 
> Here is the patch:
> 
> diff -urN linux/drivers/char/gsc_ps2.c linux-parisc/drivers/char/gsc_ps2.c
> --- linux/drivers/char/gsc_ps2.c Thu Oct 26 21:06:54 2000
> +++ linux-parisc/drivers/char/gsc_ps2.c Thu Oct 26 21:34:00 2000
> @@ -7,6 +7,11 @@
>  [.............]

> diff -urN linux/drivers/char/keyb_at.c linux-parisc/drivers/char/keyb_at.c
> --- linux/drivers/char/keyb_at.c Thu Oct 26 21:07:00 2000
> +++ linux-parisc/drivers/char/keyb_at.c Thu Oct 26 21:23:16 2000
> [........]

Hi Thomas,

Thanks for your patch. 
But I don't think it's a good idea to change a common file like keyb_at.c, 
which is used in most other arches too. This patch surely breaks their 
keyboard support and more than that I'm sure, that Linus will not accept this 
patch, when the time is come to integrate parisc into the official kernel.

Isn't there any other solution as for example to #ifdef the code or create a 
new keyb_at.c for parisc (Yes I know, both of those aren't clean too.) ?

Helge Deller