RE: [PATCH] can: m_can: m_can_chip_config(): actually enable internal timestamping

["Chandrasekar R" <rcsekar@samsung.com>]

> -----Original Message-----
> From: Marc Kleine-Budde [mailto:mkl@pengutronix.de]
> Sent: Monday, June 13, 2022 2:57 AM
> To: linux-can@vger.kernel.org
> Cc: kernel@pengutronix.de; Marc Kleine-Budde <mkl@pengutronix.de>;
> Torin Cooper-Bennun <torin@maxiluxsystems.com>; Chandrasekar
> Ramakrishnan <rcsekar@samsung.com>
> Subject: [PATCH] can: m_can: m_can_chip_config(): actually enable internal
> timestamping
> 
> In commit df06fd678260 ("can: m_can: m_can_chip_config(): enable and
> configure internal timestamps") the timestamping in the m_can core should
> be enabled. In peripheral mode, the RX'ed CAN frames, TX compete frames
> and error events are sorted by the timestamp.
> 
> The above mentioned commit however forgot to enable the timestamping.
> This patch adds the missing bits to the write of the Timestamp Counter
> Configuration register.
> 
> Fixes: df06fd678260 ("can: m_can: m_can_chip_config(): enable and
> configure internal timestamps")
> Cc: Torin Cooper-Bennun <torin@maxiluxsystems.com>
> Cc: Chandrasekar Ramakrishnan <rcsekar@samsung.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Changes looks fine, 
Reviewed-by: Chandrasekar Ramakrishnan <rcsekar@samsung.com>
> ---
>  drivers/net/can/m_can/m_can.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/m_can/m_can.c
> b/drivers/net/can/m_can/m_can.c index 5d0c82d8b9a9..03a22d493cf6
> 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -1351,7 +1351,9 @@ static void m_can_chip_config(struct net_device
> *dev)
>  	/* enable internal timestamp generation, with a prescalar of 16. The
>  	 * prescalar is applied to the nominal bit timing
>  	 */
> -	m_can_write(cdev, M_CAN_TSCC, FIELD_PREP(TSCC_TCP_MASK,
> 0xf));
> +	m_can_write(cdev, M_CAN_TSCC,
> +		    FIELD_PREP(TSCC_TCP_MASK, 0xf) |
> +		    FIELD_PREP(TSCC_TSS_MASK, TSCC_TSS_INTERNAL));
> 
>  	m_can_config_endisable(cdev, false);
> 
> --
> 2.35.1
>