RE: [PATCH v2 2/2] ALSA: hda/realtek: fix micmute LEDs on HP Laptops with ALC3247

["Simon Trimmer" <simont@opensource.cirrus.com>]

On Fri, Mar 21, 2025 at 10:49 AM Chris Chiu wrote
> More HP EliteBook with Realtek HDA codec ALC3247 with combined CS35L56
> Amplifiers need quirk ALC236_FIXUP_HP_GPIO_LED to fix the micmute LED.
> 
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
> ---
> 
> v2: fix the quirk order by SSIDs
> 
>  sound/pci/hda/patch_realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 30d4cd93dae1..5bafa8817bad 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10734,6 +10734,11 @@ static const struct hda_quirk alc269_fixup_tbl[]
> = {
>  	SND_PCI_QUIRK(0x103c, 0x8d92, "HP ZBook Firefly 16 G12",
> ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8de8, "HP Gemtree",
> ALC245_FIXUP_TAS2781_SPI_2),
>  	SND_PCI_QUIRK(0x103c, 0x8de9, "HP Gemtree",
> ALC245_FIXUP_TAS2781_SPI_2),
> +	SND_PCI_QUIRK(0x103c, 0x8dec, "HP EliteBook 640 G12",
> ALC236_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8dee, "HP EliteBook 660 G12",
> ALC236_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8df0, "HP EliteBook 630 G12",
> ALC236_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12",
> ALC236_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12",
> ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8e14, "HP ZBook Firefly 14 G12",
> ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8e15, "HP ZBook Firefly 14 G12",
> ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8e16, "HP ZBook Firefly 14 G12",
> ALC285_FIXUP_HP_GPIO_LED),
> --
> 2.34.1
> 

Looks fine to me

Reviewed-by: Simon Trimmer <simont@opensource.cirrus.com>

-Simon