From: "Seunghui Lee" <sh043.lee@samsung.com>
To: "'Bean Huo'" <huobean@gmail.com>, <alim.akhtar@samsung.com>,
<avri.altman@wdc.com>, <bvanassche@acm.org>,
<James.Bottomley@HansenPartnership.com>,
<martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>,
<sdriver.sec@samsung.com>
Subject: RE: [PATCH] ufs: core: Use link recovery when the h8 exit failure during runtime resume
Date: Thu, 17 Jul 2025 15:12:19 +0900 [thread overview]
Message-ID: <001101dbf6e1$c07a8110$416f8330$@samsung.com> (raw)
In-Reply-To: <ff93d49524dd1b79968b690753a3727e695f852d.camel@gmail.com>
> > > > Subject: Re: [PATCH] ufs: core: Use link recovery when the h8 exit
> > > > failure during runtime resume
> > > >
<snip>
>
> Based on my analysis, the tag might be:
>
> commit 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler and
> other error recovery paths"), This commit added the error handling logic
> that calls ufshcd_set_link_broken() and ufshcd_schedule_eh_work() when ret
> is non-zero in the ufshcd_uic_pwr_ctrl() function.
>
> your patch adds a check for pm_op_in_progress to skip the error handler
> and use link recovery instead during PM operations.
>
> Therefore, the appropriate Fixes tag for your patch would be:
>
> Fixes: 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler and
> other error recovery paths")
>
> But, the problem is dd11376b9f1b ("scsi: ufs: Split the drivers/scsi/ufs
> directory") reorganzied the UFS code layout, it is true that not easy to
> add a proper tag,
>
> Or we can use both fix tags, or just the last one.
>
> Let Bart comment on this,
>
> Kind regards,
> Bean
Thank you so much for sharing it.
I'll add it v2 as requested.
Fixes: 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler and
other error recovery paths")
next prev parent reply other threads:[~2025-07-17 6:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250714090630epcas1p28ab8afec11bbab4d256dfe6649d3b00b@epcas1p2.samsung.com>
2025-07-14 9:06 ` [PATCH] ufs: core: Use link recovery when the h8 exit failure during runtime resume Seunghui Lee
2025-07-14 11:21 ` Bean Huo
2025-07-15 2:23 ` 이승희
2025-07-15 12:47 ` Bean Huo
2025-07-15 15:21 ` Bean Huo
2025-07-16 7:01 ` Seunghui Lee
2025-07-16 7:49 ` Seunghui Lee
2025-07-16 13:35 ` Bean Huo
2025-07-16 15:02 ` Bart Van Assche
2025-07-17 6:12 ` Seunghui Lee [this message]
2025-07-16 15:14 ` Bart Van Assche
2025-07-17 6:01 ` Seunghui Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001101dbf6e1$c07a8110$416f8330$@samsung.com' \
--to=sh043.lee@samsung.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=huobean@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sdriver.sec@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.