diff for duplicates of <001201d3f19a$0130a860$0391f920$@codeaurora.org> diff --git a/a/1.txt b/N1/1.txt index 5e1b954..2603f4c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,7 +6,8 @@ > To: ilialin@codeaurora.org; mturquette@baylibre.com; sboyd@kernel.org; > robh@kernel.org; mark.rutland@arm.com; viresh.kumar@linaro.org; > nm@ti.com; lgirdwood@gmail.com; broonie@kernel.org; -> andy.gross@linaro.org; david.brown@linaro.org; catalin.marinas@arm.com; +> andy.gross@linaro.org; david.brown@linaro.org; = +catalin.marinas@arm.com; > will.deacon@arm.com; rjw@rjwysocki.net; linux-clk@vger.kernel.org > Cc: Sudeep Holla <sudeep.holla@arm.com>; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-pm@vger.kernel.org; linux-arm- @@ -15,13 +16,13 @@ > amit.kucheria@linaro.org; nicolas.dechesne@linaro.org; > celster@codeaurora.org; tfinkel@codeaurora.org > Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver -> -> -> +>=20 +>=20 +>=20 > On 21/05/18 13:57, ilialin@codeaurora.org wrote: > > > [...] -> +>=20 > >>> +#include <linux/cpu.h> > >>> +#include <linux/err.h> > >>> +#include <linux/init.h> @@ -39,78 +40,87 @@ > >>> +#define GOLD_LEAD 2 > >>> + > >> -> >> So I gather form other emails, that these are physical cpu number(not +> >> So I gather form other emails, that these are physical cpu = +number(not > >> even unique identifier like MPIDR). Will this work on parts or > >> platforms that need to boot in GOLD LEAD cpus. > > > > The driver is for Kryo CPU, which (and AFAIK all multicore MSMs) > > always boots on the CPU0. -> -> -> That may be true and I am not that bothered about it. But assuming physical -> ordering from the logical cpu number is *incorrect* and will break if kernel -> decides to change the allocation algorithm. Kernel provides no guarantee on -> that, so you need to depend on some physical ID or may be DT to achieve +>=20 +>=20 +> That may be true and I am not that bothered about it. But assuming = +physical +> ordering from the logical cpu number is *incorrect* and will break if = +kernel +> decides to change the allocation algorithm. Kernel provides no = +guarantee on +> that, so you need to depend on some physical ID or may be DT to = +achieve > what your want. But the current code as it stands is wrong. -Got your point. In fact CPUs are numbered 0-3 and ordered into 2 clusters in the DT: +Got your point. In fact CPUs are numbered 0-3 and ordered into 2 = +clusters in the DT: cpus { - #address-cells = <2>; - #size-cells = <0>; + #address-cells =3D <2>; + #size-cells =3D <0>; CPU0: cpu@0 { ... - reg = <0x0 0x0>; + reg =3D <0x0 0x0>; ... }; CPU1: cpu@1 { ... - reg = <0x0 0x1>; + reg =3D <0x0 0x1>; ... }; CPU2: cpu@100 { ... - reg = <0x0 0x100>; + reg =3D <0x0 0x100>; ... }; CPU3: cpu@101 { ... - reg = <0x0 0x101>; + reg =3D <0x0 0x101>; ... }; cpu-map { cluster0 { core0 { - cpu = <&CPU0>; + cpu =3D <&CPU0>; }; core1 { - cpu = <&CPU1>; + cpu =3D <&CPU1>; }; }; cluster1 { core0 { - cpu = <&CPU2>; + cpu =3D <&CPU2>; }; core1 { - cpu = <&CPU3>; + cpu =3D <&CPU3>; }; }; }; }; -As far, as I understand, they are probed in the same order. However, to be certain that the physical CPU is the one I intend to configure, I have to fetch the device structure pointer for the cpu-map -> clusterX -> core0 -> cpu path. Could you suggest a kernel API to do that? +As far, as I understand, they are probed in the same order. However, to = +be certain that the physical CPU is the one I intend to configure, I = +have to fetch the device structure pointer for the cpu-map -> clusterX = +-> core0 -> cpu path. Could you suggest a kernel API to do that? -> +>=20 > -- > Regards, > Sudeep diff --git a/a/content_digest b/N1/content_digest index 9d048e3..4ed8bcf 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -7,31 +7,31 @@ "Subject\0RE: [PATCH] cpufreq: Add Kryo CPU scaling driver\0" "Date\0Tue, 22 May 2018 09:56:19 +0300\0" "To\0'Sudeep Holla' <sudeep.holla@arm.com>" - mturquette@baylibre.com - sboyd@kernel.org - robh@kernel.org - mark.rutland@arm.com - viresh.kumar@linaro.org - nm@ti.com - lgirdwood@gmail.com - broonie@kernel.org - andy.gross@linaro.org - david.brown@linaro.org - catalin.marinas@arm.com - will.deacon@arm.com - rjw@rjwysocki.net - " linux-clk@vger.kernel.org\0" - "Cc\0devicetree@vger.kernel.org" - linux-kernel@vger.kernel.org - linux-pm@vger.kernel.org - linux-arm-msm@vger.kernel.org - linux-soc@vger.kernel.org - linux-arm-kernel@lists.infradead.org - rnayak@codeaurora.org - amit.kucheria@linaro.org - nicolas.dechesne@linaro.org - celster@codeaurora.org - " tfinkel@codeaurora.org\0" + <mturquette@baylibre.com> + <sboyd@kernel.org> + <robh@kernel.org> + <mark.rutland@arm.com> + <viresh.kumar@linaro.org> + <nm@ti.com> + <lgirdwood@gmail.com> + <broonie@kernel.org> + <andy.gross@linaro.org> + <david.brown@linaro.org> + <catalin.marinas@arm.com> + <will.deacon@arm.com> + <rjw@rjwysocki.net> + " <linux-clk@vger.kernel.org>\0" + "Cc\0<devicetree@vger.kernel.org>" + <linux-kernel@vger.kernel.org> + <linux-pm@vger.kernel.org> + <linux-arm-msm@vger.kernel.org> + <linux-soc@vger.kernel.org> + <linux-arm-kernel@lists.infradead.org> + <rnayak@codeaurora.org> + <amit.kucheria@linaro.org> + <nicolas.dechesne@linaro.org> + <celster@codeaurora.org> + " <tfinkel@codeaurora.org>\0" "\00:1\0" "b\0" "\n" @@ -42,7 +42,8 @@ "> To: ilialin@codeaurora.org; mturquette@baylibre.com; sboyd@kernel.org;\n" "> robh@kernel.org; mark.rutland@arm.com; viresh.kumar@linaro.org;\n" "> nm@ti.com; lgirdwood@gmail.com; broonie@kernel.org;\n" - "> andy.gross@linaro.org; david.brown@linaro.org; catalin.marinas@arm.com;\n" + "> andy.gross@linaro.org; david.brown@linaro.org; =\n" + "catalin.marinas@arm.com;\n" "> will.deacon@arm.com; rjw@rjwysocki.net; linux-clk@vger.kernel.org\n" "> Cc: Sudeep Holla <sudeep.holla@arm.com>; devicetree@vger.kernel.org;\n" "> linux-kernel@vger.kernel.org; linux-pm@vger.kernel.org; linux-arm-\n" @@ -51,13 +52,13 @@ "> amit.kucheria@linaro.org; nicolas.dechesne@linaro.org;\n" "> celster@codeaurora.org; tfinkel@codeaurora.org\n" "> Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver\n" - "> \n" - "> \n" - "> \n" + ">=20\n" + ">=20\n" + ">=20\n" "> On 21/05/18 13:57, ilialin@codeaurora.org wrote:\n" "> >\n" "> [...]\n" - "> \n" + ">=20\n" "> >>> +#include <linux/cpu.h>\n" "> >>> +#include <linux/err.h>\n" "> >>> +#include <linux/init.h>\n" @@ -75,80 +76,89 @@ "> >>> +#define GOLD_LEAD\t2\n" "> >>> +\n" "> >>\n" - "> >> So I gather form other emails, that these are physical cpu number(not\n" + "> >> So I gather form other emails, that these are physical cpu =\n" + "number(not\n" "> >> even unique identifier like MPIDR). Will this work on parts or\n" "> >> platforms that need to boot in GOLD LEAD cpus.\n" "> >\n" "> > The driver is for Kryo CPU, which (and AFAIK all multicore MSMs)\n" "> > always boots on the CPU0.\n" - "> \n" - "> \n" - "> That may be true and I am not that bothered about it. But assuming physical\n" - "> ordering from the logical cpu number is *incorrect* and will break if kernel\n" - "> decides to change the allocation algorithm. Kernel provides no guarantee on\n" - "> that, so you need to depend on some physical ID or may be DT to achieve\n" + ">=20\n" + ">=20\n" + "> That may be true and I am not that bothered about it. But assuming =\n" + "physical\n" + "> ordering from the logical cpu number is *incorrect* and will break if =\n" + "kernel\n" + "> decides to change the allocation algorithm. Kernel provides no =\n" + "guarantee on\n" + "> that, so you need to depend on some physical ID or may be DT to =\n" + "achieve\n" "> what your want. But the current code as it stands is wrong.\n" "\n" - "Got your point. In fact CPUs are numbered 0-3 and ordered into 2 clusters in the DT:\n" + "Got your point. In fact CPUs are numbered 0-3 and ordered into 2 =\n" + "clusters in the DT:\n" "\n" "cpus {\n" - "\t#address-cells = <2>;\n" - "\t#size-cells = <0>;\n" + "\t#address-cells =3D <2>;\n" + "\t#size-cells =3D <0>;\n" "\n" "\tCPU0: cpu@0 {\n" "\t\t...\n" - "\t\treg = <0x0 0x0>;\n" + "\t\treg =3D <0x0 0x0>;\n" "\t\t...\n" "\t};\n" "\n" "\tCPU1: cpu@1 {\n" "\t\t...\n" - "\t\treg = <0x0 0x1>;\n" + "\t\treg =3D <0x0 0x1>;\n" "\t\t...\n" "\t};\n" "\n" "\tCPU2: cpu@100 {\n" "\t\t...\n" - "\t\treg = <0x0 0x100>;\n" + "\t\treg =3D <0x0 0x100>;\n" "\t\t...\n" "\t};\n" "\n" "\tCPU3: cpu@101 {\n" "\t\t...\n" - "\t\treg = <0x0 0x101>;\n" + "\t\treg =3D <0x0 0x101>;\n" "\t\t...\n" "\t};\n" "\n" "\tcpu-map {\n" "\t\tcluster0 {\n" "\t\t\tcore0 {\n" - "\t\t\t\tcpu = <&CPU0>;\n" + "\t\t\t\tcpu =3D <&CPU0>;\n" "\t\t\t};\n" "\n" "\t\t\tcore1 {\n" - "\t\t\t\tcpu = <&CPU1>;\n" + "\t\t\t\tcpu =3D <&CPU1>;\n" "\t\t\t};\n" "\t\t};\n" "\n" "\t\tcluster1 {\n" "\t\t\tcore0 {\n" - "\t\t\t\tcpu = <&CPU2>;\n" + "\t\t\t\tcpu =3D <&CPU2>;\n" "\t\t\t};\n" "\n" "\t\t\tcore1 {\n" - "\t\t\t\tcpu = <&CPU3>;\n" + "\t\t\t\tcpu =3D <&CPU3>;\n" "\t\t\t};\n" "\t\t};\n" "\t};\n" "};\n" "\n" - "As far, as I understand, they are probed in the same order. However, to be certain that the physical CPU is the one I intend to configure, I have to fetch the device structure pointer for the cpu-map -> clusterX -> core0 -> cpu path. Could you suggest a kernel API to do that?\n" + "As far, as I understand, they are probed in the same order. However, to =\n" + "be certain that the physical CPU is the one I intend to configure, I =\n" + "have to fetch the device structure pointer for the cpu-map -> clusterX =\n" + "-> core0 -> cpu path. Could you suggest a kernel API to do that?\n" "\n" "\n" "\n" - "> \n" + ">=20\n" "> --\n" "> Regards,\n" > Sudeep -d3a012f7d9e2bb19bc88c0d86dd39e0cce366ce2124bb278e3018932b32d9e35 +7fec18eb8fa9ee59d71cc468700c68d0cb8bd4519c661c2ba85de413c826dcce
diff --git a/a/1.txt b/N2/1.txt index 5e1b954..00057c9 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -3,22 +3,22 @@ > -----Original Message----- > From: Sudeep Holla <sudeep.holla@arm.com> > Sent: Monday, May 21, 2018 16:05 -> To: ilialin@codeaurora.org; mturquette@baylibre.com; sboyd@kernel.org; -> robh@kernel.org; mark.rutland@arm.com; viresh.kumar@linaro.org; -> nm@ti.com; lgirdwood@gmail.com; broonie@kernel.org; -> andy.gross@linaro.org; david.brown@linaro.org; catalin.marinas@arm.com; -> will.deacon@arm.com; rjw@rjwysocki.net; linux-clk@vger.kernel.org -> Cc: Sudeep Holla <sudeep.holla@arm.com>; devicetree@vger.kernel.org; -> linux-kernel@vger.kernel.org; linux-pm@vger.kernel.org; linux-arm- -> msm@vger.kernel.org; linux-soc@vger.kernel.org; linux-arm- -> kernel@lists.infradead.org; rnayak@codeaurora.org; -> amit.kucheria@linaro.org; nicolas.dechesne@linaro.org; -> celster@codeaurora.org; tfinkel@codeaurora.org +> To: ilialin at codeaurora.org; mturquette at baylibre.com; sboyd at kernel.org; +> robh at kernel.org; mark.rutland at arm.com; viresh.kumar at linaro.org; +> nm at ti.com; lgirdwood at gmail.com; broonie at kernel.org; +> andy.gross at linaro.org; david.brown at linaro.org; catalin.marinas at arm.com; +> will.deacon at arm.com; rjw at rjwysocki.net; linux-clk at vger.kernel.org +> Cc: Sudeep Holla <sudeep.holla@arm.com>; devicetree at vger.kernel.org; +> linux-kernel at vger.kernel.org; linux-pm at vger.kernel.org; linux-arm- +> msm at vger.kernel.org; linux-soc at vger.kernel.org; linux-arm- +> kernel at lists.infradead.org; rnayak at codeaurora.org; +> amit.kucheria at linaro.org; nicolas.dechesne at linaro.org; +> celster at codeaurora.org; tfinkel at codeaurora.org > Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver > > > -> On 21/05/18 13:57, ilialin@codeaurora.org wrote: +> On 21/05/18 13:57, ilialin at codeaurora.org wrote: > > > [...] > @@ -59,25 +59,25 @@ cpus { #address-cells = <2>; #size-cells = <0>; - CPU0: cpu@0 { + CPU0: cpu at 0 { ... reg = <0x0 0x0>; ... }; - CPU1: cpu@1 { + CPU1: cpu at 1 { ... reg = <0x0 0x1>; ... }; - CPU2: cpu@100 { + CPU2: cpu at 100 { ... reg = <0x0 0x100>; ... }; - CPU3: cpu@101 { + CPU3: cpu at 101 { ... reg = <0x0 0x101>; ... diff --git a/a/content_digest b/N2/content_digest index 9d048e3..9962fdd 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,35 +3,10 @@ "ref\0153cc316-dcb5-972f-5a2f-c91fe0f6348b@arm.com\0" "ref\0000f01d3f103$3ff78ba0$bfe6a2e0$@codeaurora.org\0" "ref\02ace10bc-e1c4-2060-94d3-eb71e966ffbe@arm.com\0" - "From\0<ilialin@codeaurora.org>\0" - "Subject\0RE: [PATCH] cpufreq: Add Kryo CPU scaling driver\0" + "From\0ilialin@codeaurora.org (ilialin at codeaurora.org)\0" + "Subject\0[PATCH] cpufreq: Add Kryo CPU scaling driver\0" "Date\0Tue, 22 May 2018 09:56:19 +0300\0" - "To\0'Sudeep Holla' <sudeep.holla@arm.com>" - mturquette@baylibre.com - sboyd@kernel.org - robh@kernel.org - mark.rutland@arm.com - viresh.kumar@linaro.org - nm@ti.com - lgirdwood@gmail.com - broonie@kernel.org - andy.gross@linaro.org - david.brown@linaro.org - catalin.marinas@arm.com - will.deacon@arm.com - rjw@rjwysocki.net - " linux-clk@vger.kernel.org\0" - "Cc\0devicetree@vger.kernel.org" - linux-kernel@vger.kernel.org - linux-pm@vger.kernel.org - linux-arm-msm@vger.kernel.org - linux-soc@vger.kernel.org - linux-arm-kernel@lists.infradead.org - rnayak@codeaurora.org - amit.kucheria@linaro.org - nicolas.dechesne@linaro.org - celster@codeaurora.org - " tfinkel@codeaurora.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "\n" @@ -39,22 +14,22 @@ "> -----Original Message-----\n" "> From: Sudeep Holla <sudeep.holla@arm.com>\n" "> Sent: Monday, May 21, 2018 16:05\n" - "> To: ilialin@codeaurora.org; mturquette@baylibre.com; sboyd@kernel.org;\n" - "> robh@kernel.org; mark.rutland@arm.com; viresh.kumar@linaro.org;\n" - "> nm@ti.com; lgirdwood@gmail.com; broonie@kernel.org;\n" - "> andy.gross@linaro.org; david.brown@linaro.org; catalin.marinas@arm.com;\n" - "> will.deacon@arm.com; rjw@rjwysocki.net; linux-clk@vger.kernel.org\n" - "> Cc: Sudeep Holla <sudeep.holla@arm.com>; devicetree@vger.kernel.org;\n" - "> linux-kernel@vger.kernel.org; linux-pm@vger.kernel.org; linux-arm-\n" - "> msm@vger.kernel.org; linux-soc@vger.kernel.org; linux-arm-\n" - "> kernel@lists.infradead.org; rnayak@codeaurora.org;\n" - "> amit.kucheria@linaro.org; nicolas.dechesne@linaro.org;\n" - "> celster@codeaurora.org; tfinkel@codeaurora.org\n" + "> To: ilialin at codeaurora.org; mturquette at baylibre.com; sboyd at kernel.org;\n" + "> robh at kernel.org; mark.rutland at arm.com; viresh.kumar at linaro.org;\n" + "> nm at ti.com; lgirdwood at gmail.com; broonie at kernel.org;\n" + "> andy.gross at linaro.org; david.brown at linaro.org; catalin.marinas at arm.com;\n" + "> will.deacon at arm.com; rjw at rjwysocki.net; linux-clk at vger.kernel.org\n" + "> Cc: Sudeep Holla <sudeep.holla@arm.com>; devicetree at vger.kernel.org;\n" + "> linux-kernel at vger.kernel.org; linux-pm at vger.kernel.org; linux-arm-\n" + "> msm at vger.kernel.org; linux-soc at vger.kernel.org; linux-arm-\n" + "> kernel at lists.infradead.org; rnayak at codeaurora.org;\n" + "> amit.kucheria at linaro.org; nicolas.dechesne at linaro.org;\n" + "> celster at codeaurora.org; tfinkel at codeaurora.org\n" "> Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver\n" "> \n" "> \n" "> \n" - "> On 21/05/18 13:57, ilialin@codeaurora.org wrote:\n" + "> On 21/05/18 13:57, ilialin at codeaurora.org wrote:\n" "> >\n" "> [...]\n" "> \n" @@ -95,25 +70,25 @@ "\t#address-cells = <2>;\n" "\t#size-cells = <0>;\n" "\n" - "\tCPU0: cpu@0 {\n" + "\tCPU0: cpu at 0 {\n" "\t\t...\n" "\t\treg = <0x0 0x0>;\n" "\t\t...\n" "\t};\n" "\n" - "\tCPU1: cpu@1 {\n" + "\tCPU1: cpu at 1 {\n" "\t\t...\n" "\t\treg = <0x0 0x1>;\n" "\t\t...\n" "\t};\n" "\n" - "\tCPU2: cpu@100 {\n" + "\tCPU2: cpu at 100 {\n" "\t\t...\n" "\t\treg = <0x0 0x100>;\n" "\t\t...\n" "\t};\n" "\n" - "\tCPU3: cpu@101 {\n" + "\tCPU3: cpu at 101 {\n" "\t\t...\n" "\t\treg = <0x0 0x101>;\n" "\t\t...\n" @@ -151,4 +126,4 @@ "> Regards,\n" > Sudeep -d3a012f7d9e2bb19bc88c0d86dd39e0cce366ce2124bb278e3018932b32d9e35 +5c06cc703f2700d8f536f65bb58d3a5c1cd6c348580a90d568c1fd583c3ff58e
diff --git a/a/content_digest b/N3/content_digest index 9d048e3..11976ae 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -7,31 +7,31 @@ "Subject\0RE: [PATCH] cpufreq: Add Kryo CPU scaling driver\0" "Date\0Tue, 22 May 2018 09:56:19 +0300\0" "To\0'Sudeep Holla' <sudeep.holla@arm.com>" - mturquette@baylibre.com - sboyd@kernel.org - robh@kernel.org - mark.rutland@arm.com - viresh.kumar@linaro.org - nm@ti.com - lgirdwood@gmail.com - broonie@kernel.org - andy.gross@linaro.org - david.brown@linaro.org - catalin.marinas@arm.com - will.deacon@arm.com - rjw@rjwysocki.net - " linux-clk@vger.kernel.org\0" - "Cc\0devicetree@vger.kernel.org" - linux-kernel@vger.kernel.org - linux-pm@vger.kernel.org - linux-arm-msm@vger.kernel.org - linux-soc@vger.kernel.org - linux-arm-kernel@lists.infradead.org - rnayak@codeaurora.org - amit.kucheria@linaro.org - nicolas.dechesne@linaro.org - celster@codeaurora.org - " tfinkel@codeaurora.org\0" + <mturquette@baylibre.com> + <sboyd@kernel.org> + <robh@kernel.org> + <mark.rutland@arm.com> + <viresh.kumar@linaro.org> + <nm@ti.com> + <lgirdwood@gmail.com> + <broonie@kernel.org> + <andy.gross@linaro.org> + <david.brown@linaro.org> + <catalin.marinas@arm.com> + <will.deacon@arm.com> + <rjw@rjwysocki.net> + " <linux-clk@vger.kernel.org>\0" + "Cc\0<devicetree@vger.kernel.org>" + <linux-kernel@vger.kernel.org> + <linux-pm@vger.kernel.org> + <linux-arm-msm@vger.kernel.org> + <linux-soc@vger.kernel.org> + <linux-arm-kernel@lists.infradead.org> + <rnayak@codeaurora.org> + <amit.kucheria@linaro.org> + <nicolas.dechesne@linaro.org> + <celster@codeaurora.org> + " <tfinkel@codeaurora.org>\0" "\00:1\0" "b\0" "\n" @@ -151,4 +151,4 @@ "> Regards,\n" > Sudeep -d3a012f7d9e2bb19bc88c0d86dd39e0cce366ce2124bb278e3018932b32d9e35 +c19fa6cef25d3532cdd2604a9e91fd125e208e43bc54edcb85667710afbecaf1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.