Re: [PATCH net-next] net/iucv: Add lock nesting annotation in iucv_sock_close()

[Alexandra Winter <wintera@linux.ibm.com>]

On 13.09.26 15:42, Simon Horman wrote:
> On Fri, Sep 11, 2026 at 04:29:45PM +0000, sashiko-bot@kernel.org wrote:
>> Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
>>
>> Pre-existing issues:
>> - [Critical] Lockless traversal of accept_q causes list corruption and use-after-free due to concurrent modifications from softirq context.
>> - [High] Newly allocated sockets are permanently leaked on error paths because iucv_sock_kill() returns early if SOCK_ZAPPED is not set.
>> - [High] Child socket leak in iucv_sock_cleanup_listen due to late state update leaving a race window.
>> - [High] Unprotected state modifications in iucv_callback_connack cause state desynchronization.
> 
> My opinion is that the issues above are all orthogonal to this patch
> and should not block progress of it.
> 
> ...

I agree. I think all of them were reported already by Bryam Vargas [1]
I need to get this one out of the way, so I can reproduce the real issues.


Linkk: https://lore.kernel.org/netdev/20260724222917.134769-1-hexlabsecurity@proton.me/ [1]