From: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: 'Olof Johansson' <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: 'Wolfram Sang' <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
'Sekhar Nori' <nsekhar-l0cyMroinI0@public.gmane.org>,
'Kevin Hilman'
<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
'Jingoo Han' <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] i2c: davinci: Fix bad dev_get_platdata() conversion
Date: Fri, 06 Sep 2013 09:08:43 +0900 [thread overview]
Message-ID: <001901ceaa95$3fca88d0$bf5f9a70$%han@samsung.com> (raw)
In-Reply-To: <1378409024-13432-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
On Friday, September 06, 2013 4:24 AM, Olof Johansson wrote:
>
> commit 6d4028c644e (i2c: use dev_get_platdata()) did a bad conversion
> of this one case:
>
> drivers/i2c/busses/i2c-davinci.c: In function 'davinci_i2c_probe':
> drivers/i2c/busses/i2c-davinci.c:665:2: warning: passing argument 1 of
> 'dev_get_platdata' from incompatible pointer type [enabled by default]
>
> Cc: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Reviewed-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Oh, it's my bad. :-(
Thank you for fixing it.
Best regards,
Jingoo Han
> ---
> drivers/i2c/busses/i2c-davinci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> index 5747341..132369f 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
> @@ -662,7 +662,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
> #endif
> dev->dev = &pdev->dev;
> dev->irq = irq->start;
> - dev->pdata = dev_get_platdata(&dev->dev);
> + dev->pdata = dev_get_platdata(&pdev->dev);
> platform_set_drvdata(pdev, dev);
>
> if (!dev->pdata && pdev->dev.of_node) {
> --
> 1.7.10.4
next prev parent reply other threads:[~2013-09-06 0:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 19:23 [PATCH] i2c: davinci: Fix bad dev_get_platdata() conversion Olof Johansson
[not found] ` <1378409024-13432-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2013-09-06 0:08 ` Jingoo Han [this message]
2013-09-10 9:20 ` Wolfram Sang
2013-09-10 9:25 ` Jingoo Han
[not found] ` <007401ceae07$a70b41e0$f521c5a0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-10 21:26 ` Olof Johansson
[not found] ` <CAOesGMiNaQyLz3bOQzu4bQ_jJBh=g8uLZxLtHvDEAxefEZYAVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-11 0:27 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001901ceaa95$3fca88d0$bf5f9a70$%han@samsung.com' \
--to=jg1.han-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.