From: "Manfred Spraul" <manfred@colorfullife.com>
To: "Robert Love" <rml@tech9.net>
Cc: "Roger Larsson" <roger.larsson@norran.net>,
<linux-kernel@vger.kernel.org>, <nigel@nrg.org>
Subject: Re: [SMP lock BUG?] Re: Feedback on preemptible kernel patch
Date: Sun, 9 Sep 2001 09:38:16 +0200 [thread overview]
Message-ID: <001a01c13902$762c7f30$010411ac@local> (raw)
In-Reply-To: <000901c138bb$8e151270$010411ac@local> <1000007070.836.14.camel@phantasy>
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
> #define kmap_atomic(page,idx) ctx_sw_off(); kmap(page);
> #define kunmap_atomic(page,idx) ctx_sw_on(); kunmap(page);
>
No. kmap_atomic is called from interrupt context, and kmap calls
schedule().
I thought about the attached patch (completely untested).
--
Manfred
[-- Attachment #2: patch-untested --]
[-- Type: application/octet-stream, Size: 438 bytes --]
--- highmem.h.prev Sun Sep 9 08:59:04 2001
+++ highmem.h Sun Sep 9 09:00:07 2001
@@ -88,6 +88,7 @@
if (page < highmem_start_page)
return page_address(page);
+ ctx_sw_off();
idx = type + KM_TYPE_NR*smp_processor_id();
vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx);
#if HIGHMEM_DEBUG
@@ -119,6 +120,7 @@
pte_clear(kmap_pte-idx);
__flush_tlb_one(vaddr);
#endif
+ ctx_sw_on();
}
#endif /* __KERNEL__ */
next prev parent reply other threads:[~2001-09-09 7:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-08 23:11 [SMP lock BUG?] Re: Feedback on preemptible kernel patch Manfred Spraul
2001-09-09 3:44 ` Robert Love
2001-09-09 7:38 ` Manfred Spraul [this message]
[not found] ` <001a01c1390262c7f30/mnt/sendme10411ac@local>
2001-09-14 9:15 ` Pavel Machek
2001-09-17 22:40 ` Manfred Spraul
2001-09-18 0:19 ` Robert Love
2001-09-17 22:41 ` Robert Love
-- strict thread matches above, loose matches on Subject: below --
2001-09-08 17:33 Arjan Filius
2001-09-08 20:58 ` [SMP lock BUG?] " Roger Larsson
2001-09-08 20:58 ` Roger Larsson
2001-09-08 22:18 ` Arjan Filius
2001-09-08 22:18 ` Arjan Filius
2001-09-09 14:55 ` george anzinger
2001-09-09 14:55 ` george anzinger
2001-09-09 22:25 ` Arjan Filius
2001-09-09 22:25 ` Arjan Filius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001a01c13902$762c7f30$010411ac@local' \
--to=manfred@colorfullife.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@nrg.org \
--cc=rml@tech9.net \
--cc=roger.larsson@norran.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.