All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Doug Smythies" <dsmythies@telus.net>
To: 'Srinivas Pandruvada' <srinivas.pandruvada@linux.intel.com>,
	"'Rafael J. Wysocki'" <rjw@rjwysocki.net>
Cc: 'Linux Kernel Mailing List' <linux-kernel@vger.kernel.org>,
	'Linux PM list' <linux-pm@vger.kernel.org>
Subject: RE: [PATCH] intel_pstate: Update cpu_frequency tracepoint every time
Date: Tue, 19 Jul 2016 20:14:53 -0700	[thread overview]
Message-ID: <001a01d1e234$e33ce290$a9b6a7b0$@net> (raw)
In-Reply-To: <1468967958.2125.2.camel@linux.intel.com>

On 2016.07.19 15:10 Srinivas Pandruvada wrote:
> On Tue, 2016-07-19 at 15:10 +0200, Rafael J. Wysocki wrote:
>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> 
>> Currently, intel_pstate only updates the cpu_frequency tracepoint
>> if the new P-state to set is different from the current one, but
>> that causes powertop to report 100% idle on an 100% loaded system
>> sometimes.
>> 
>> Prevent that from happening by updating the cpu_frequency tracepoint
>> every time intel_pstate_update_pstate() is called.
>> 
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>-

Shouldn't this patch refer to:

commit fdfdb2b1301670a69195ba1e5666df4a7f02eb46
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date:   Fri Mar 18 23:20:02 2016 +0100

    intel_pstate: Do not call wrmsrl_on_cpu() with disabled interrupts

which is the patch that introduced the regression?

... Doug

  reply	other threads:[~2016-07-20  3:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 13:10 [PATCH] intel_pstate: Update cpu_frequency tracepoint every time Rafael J. Wysocki
2016-07-19 22:39 ` Srinivas Pandruvada
2016-07-20  3:14   ` Doug Smythies [this message]
2016-07-23 12:41     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001a01d1e234$e33ce290$a9b6a7b0$@net' \
    --to=dsmythies@telus.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.