From: "Santosh Abraham" <santosha@india.hp.com>
To: "'David S. Miller'" <davem@redhat.com>
Cc: <willy@debian.org>, <randolph@tausq.org>,
<parisc-linux@lists.parisc-linux.org>, <sct@redhat.com>
Subject: RE: [parisc-linux] Fwd: Problems with raw interface.
Date: Fri, 26 Sep 2003 17:42:29 +0530 [thread overview]
Message-ID: <001b01c38427$76328840$e5624c0f@india.hp.com> (raw)
In-Reply-To: <20030926033458.68dbb768.davem@redhat.com>
Apologies for 1) & 2). I guess ignorance is not bliss or excusable,
is it :)
As for 3) i agree that there are issues, but what are the alternatives
we have ?
Assuming that you agree that we need to call flush_cache_range ( ) to fix
the issue.
1) Call flush_cache_range () directly before the call to
flush_dcache_page (). But this could impact other architectures
too, right ?
2) Modify flush_dcache_page () in asm-parisc/pgalloc.h to handle
this. But this is not easy cause we do not pass the user VA in
flush_dcache_page ().
-----Original Message-----
From: David S. Miller [mailto:davem@redhat.com]
Sent: Friday, September 26, 2003 4:05 PM
To: santosh.abraham@hp.com
Cc: santosha@india.hp.com; willy@debian.org; randolph@tausq.org;
parisc-linux@lists.parisc-linux.org; sct@redhat.com
Subject: Re: [parisc-linux] Fwd: Problems with raw interface.
1) Please use unified diffs when you post patches.
2) If you insist on using Microsoft Outlook when posting patches
at least configure it properly when doing so. By default it is
going to turn tabs into spaces and that makes the patch corrupt
and unusable by anyone.
3) Your patch is unacceptable because it is taking advantage
of internal implementation details of flush_dcache_page()
on parisc64 that might not (and in fact, is not) be true
on other platforms.
prev parent reply other threads:[~2003-09-26 12:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-25 10:38 [parisc-linux] Fwd: Problems with raw interface Santosh Abraham
2003-09-25 10:50 ` Randolph Chung
2003-09-25 11:19 ` Santosh Abraham
2003-09-25 14:26 ` Matthew Wilcox
2003-09-26 1:08 ` David S. Miller
2003-09-26 11:24 ` Matthew Wilcox
2003-09-26 11:20 ` David S. Miller
2003-09-26 11:57 ` Stephen C. Tweedie
2003-09-26 11:48 ` David S. Miller
2003-09-26 12:20 ` Matthew Wilcox
2003-09-26 12:38 ` David S. Miller
2003-09-26 13:11 ` SANTOSH ABRAHAM
2003-09-26 12:56 ` David S. Miller
2003-09-26 13:29 ` Matthew Wilcox
2003-09-26 13:21 ` David S. Miller
2003-09-26 14:09 ` Matthew Wilcox
2003-09-26 14:04 ` David S. Miller
2003-09-26 14:30 ` Matthew Wilcox
2003-09-26 14:20 ` David S. Miller
2003-09-26 14:42 ` Stephen C. Tweedie
2003-09-26 14:26 ` Stephen C. Tweedie
2003-09-26 11:47 ` Santosh Abraham
2003-09-26 10:42 ` Santosh Abraham
2003-09-26 10:34 ` David S. Miller
2003-09-26 12:12 ` Santosh Abraham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001b01c38427$76328840$e5624c0f@india.hp.com' \
--to=santosha@india.hp.com \
--cc=davem@redhat.com \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=randolph@tausq.org \
--cc=santosh.abraham@hp.com \
--cc=sct@redhat.com \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.