All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: perf: reset counters on all CPUs during initialisation
Date: Wed, 16 Mar 2011 16:21:09 -0000	[thread overview]
Message-ID: <001b01cbe3f6$29365e40$7ba31ac0$@deacon@arm.com> (raw)
In-Reply-To: <AANLkTim_XwErHv_Brkn5hXn7sAxvkd++C5wbKv9n4VXC@mail.gmail.com>

Hi Jean,

> On Wed, Mar 16, 2011 at 4:38 PM, Will Deacon <will.deacon@arm.com> wrote:
> > ARMv7 dictates that the interrupt-enable and count-enable registers for
> > each PMU counter are UNKNOWN following core reset.
> Great! Is this development driven by actual issues or by precaution?

Just precautionary, but it's also a precursor to some power management
work in ARM which might leave the registers in a funny state when they
come out of a low-power state. This code at least gives them an entry
hook for dealing with that.
 
> >
> > This patch adds an arch_initcall to the ARMv7 perf events backend which
> > disables the counters on each CPU prior to setting the Enable bit in the
> > PMCR.
> Also the function rename is a good thing.

Yup.

> >
> > Cc: Jean Pihet <jean.pihet@newoldbits.com>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> 
> Acked-by: Jean Pihet <j-pihet@ti.com>

Thanks for the Ack,

Will

  reply	other threads:[~2011-03-16 16:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16 15:38 [PATCH 1/2] ARM: perf: reset counters on all CPUs during initialisation Will Deacon
2011-03-16 15:38 ` [PATCH 2/2] ARM: perf: add required isbs() to ARMv7 backend Will Deacon
2011-03-16 16:00   ` Jean Pihet
2011-03-16 16:34     ` Will Deacon
2011-03-21 18:22     ` Will Deacon
     [not found]     ` <9133336726495377032@unknownmsgid>
2011-03-21 19:22       ` Jean Pihet
2011-03-22 13:24         ` Will Deacon
2011-03-16 15:58 ` [PATCH 1/2] ARM: perf: reset counters on all CPUs during initialisation Jean Pihet
2011-03-16 16:21   ` Will Deacon [this message]
2011-03-23 13:39   ` Will Deacon
     [not found]   ` <-7053270875332574934@unknownmsgid>
2011-03-23 15:01     ` Jean Pihet
2011-03-23 15:07       ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001b01cbe3f6$29365e40$7ba31ac0$@deacon@arm.com' \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.