From: Jungseok Lee <jays.lee@samsung.com>
To: 'Christoffer Dall' <christoffer.dall@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, Catalin.Marinas@arm.com,
'Marc Zyngier' <Marc.Zyngier@arm.com>,
linux-kernel@vger.kernel.org,
'linux-samsung-soc' <linux-samsung-soc@vger.kernel.org>,
steve.capper@linaro.org, sungjinn.chung@samsung.com,
'Arnd Bergmann' <arnd@arndb.de>,
kgene.kim@samsung.com, ilho215.lee@samsung.com
Subject: Re: [PATCH v5 2/6] arm64: Introduce VA_BITS and translation level options
Date: Wed, 07 May 2014 12:59:12 +0900 [thread overview]
Message-ID: <001b01cf69a8$b49e5010$1ddaf030$@samsung.com> (raw)
In-Reply-To: <20140502111648.GA3002@lvm>
On Friday, May 02, 2014 8:17 PM, Christoffer Dall wrote:
> On Fri, May 02, 2014 at 10:57:09AM +0900, Jungseok Lee wrote:
> > On Thursday, May 01, 2014 7:06 PM, Christoffer Dall wrote:
> > > On Thu, May 01, 2014 at 11:33:56AM +0900, Jungseok Lee wrote:
>
> [...]
>
> > > > +
> > > > +choice
> > > > + prompt "Virtual address space size"
> > > > + default ARM64_VA_BITS_39 if ARM64_4K_PAGES
> > > > + default ARM64_VA_BITS_42 if ARM64_64K_PAGES
> > > > + help
> > > > + Allows virtual address space size. A level of translation
> > > > +tables
> > >
> > > What does "Allows virtual address space size" mean exactly?
> >
> > It means that VA space size can be chosen. For example, there are two
> > VA size options, 39-bit and 48-bit, with 4KB pages. If 39-bit VA space
> > is not enough, 48-bit can be selected instead. The 5th patch adds a
> > 48-bit option to this choice blocks.
> >
> > If 16KB pages are supported with both 47-bit and 48-bit VA size,
> > people could configure it in menuconfig.
> >
> > In this context, I've written it down like page size.
> >
> > I think Catalin's comment would be helpful.
> > http://www.spinics.net/linux/lists/arm-kernel/msg319552.html
> >
> I didn't have problems understanding the concept, I was questioning the language. The way it is
> written now it suggests having a virtual address space size, as opposed to not having a size at all,
> which doesn't make sense.
>
> I think you want to say something along the lines of "Allows choosing a virtual address space size",
> or "Allows choosing one of multiple possible virtual address space sizes".
Ahh... I see. I will revise the sentence clearly.
Thanks!
- Jungseok Lee
WARNING: multiple messages have this Message-ID (diff)
From: jays.lee@samsung.com (Jungseok Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/6] arm64: Introduce VA_BITS and translation level options
Date: Wed, 07 May 2014 12:59:12 +0900 [thread overview]
Message-ID: <001b01cf69a8$b49e5010$1ddaf030$@samsung.com> (raw)
In-Reply-To: <20140502111648.GA3002@lvm>
On Friday, May 02, 2014 8:17 PM, Christoffer Dall wrote:
> On Fri, May 02, 2014 at 10:57:09AM +0900, Jungseok Lee wrote:
> > On Thursday, May 01, 2014 7:06 PM, Christoffer Dall wrote:
> > > On Thu, May 01, 2014 at 11:33:56AM +0900, Jungseok Lee wrote:
>
> [...]
>
> > > > +
> > > > +choice
> > > > + prompt "Virtual address space size"
> > > > + default ARM64_VA_BITS_39 if ARM64_4K_PAGES
> > > > + default ARM64_VA_BITS_42 if ARM64_64K_PAGES
> > > > + help
> > > > + Allows virtual address space size. A level of translation
> > > > +tables
> > >
> > > What does "Allows virtual address space size" mean exactly?
> >
> > It means that VA space size can be chosen. For example, there are two
> > VA size options, 39-bit and 48-bit, with 4KB pages. If 39-bit VA space
> > is not enough, 48-bit can be selected instead. The 5th patch adds a
> > 48-bit option to this choice blocks.
> >
> > If 16KB pages are supported with both 47-bit and 48-bit VA size,
> > people could configure it in menuconfig.
> >
> > In this context, I've written it down like page size.
> >
> > I think Catalin's comment would be helpful.
> > http://www.spinics.net/linux/lists/arm-kernel/msg319552.html
> >
> I didn't have problems understanding the concept, I was questioning the language. The way it is
> written now it suggests having a virtual address space size, as opposed to not having a size at all,
> which doesn't make sense.
>
> I think you want to say something along the lines of "Allows choosing a virtual address space size",
> or "Allows choosing one of multiple possible virtual address space sizes".
Ahh... I see. I will revise the sentence clearly.
Thanks!
- Jungseok Lee
next prev parent reply other threads:[~2014-05-07 3:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 2:33 [PATCH v5 2/6] arm64: Introduce VA_BITS and translation level options Jungseok Lee
2014-05-01 2:33 ` Jungseok Lee
2014-05-01 10:06 ` Christoffer Dall
2014-05-01 10:06 ` Christoffer Dall
2014-05-02 1:57 ` Jungseok Lee
2014-05-02 1:57 ` Jungseok Lee
2014-05-02 11:16 ` Christoffer Dall
2014-05-02 11:16 ` Christoffer Dall
2014-05-07 3:59 ` Jungseok Lee [this message]
2014-05-07 3:59 ` Jungseok Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001b01cf69a8$b49e5010$1ddaf030$@samsung.com' \
--to=jays.lee@samsung.com \
--cc=Catalin.Marinas@arm.com \
--cc=Marc.Zyngier@arm.com \
--cc=arnd@arndb.de \
--cc=christoffer.dall@linaro.org \
--cc=ilho215.lee@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=steve.capper@linaro.org \
--cc=sungjinn.chung@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.