All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roberto García" <rodanber@gmail.com>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Netfilter Development Mailing list
	<netfilter-devel@vger.kernel.org>,
	Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH] iptables: extensions: libxt_ecn: Add translation to nft
Date: Wed, 29 Jun 2016 10:50:54 +0200	[thread overview]
Message-ID: <001bc6b7-7d4f-5cea-5761-00143d4accdd@gmail.com> (raw)
In-Reply-To: <CAOkSjBg9y-NoqyHV38-SeG_LUjg2UbjozJ=-PXDWgcMDSDT45Q@mail.gmail.com>

Ok, gonna fix that ASAP.

On 29/06/16 10:29, Arturo Borrero Gonzalez wrote:
> On 28 June 2016 at 21:58,  <rodanber@gmail.com> wrote:
>> diff --git a/extensions/libxt_ecn.c b/extensions/libxt_ecn.c
>> index 286782a..8e0c35b 100644
>> --- a/extensions/libxt_ecn.c
>> +++ b/extensions/libxt_ecn.c
>> @@ -118,6 +118,50 @@ static void ecn_save(const void *ip, const struct xt_entry_match *match)
>>         }
>>  }
>>
>> +static int ecn_xlate(const void *ip, const struct xt_entry_match *match,
>> +                    struct xt_xlate *xl, int numeric)
>> +{
>> +       const struct xt_ecn_info *einfo =
>> +               (const struct xt_ecn_info *)match->data;
>> +
>> +       if (einfo->operation & XT_ECN_OP_MATCH_IP) {
>
> You could also do an early return here, given the case of this if ()
> failing we have nothing to translate.
>

  reply	other threads:[~2016-06-29  8:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 19:58 [PATCH] iptables: extensions: libxt_ecn: Add translation to nft rodanber
2016-06-29  6:41 ` Arturo Borrero Gonzalez
2016-06-29  8:29 ` Arturo Borrero Gonzalez
2016-06-29  8:50   ` Roberto García [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-06-29  9:24 rodanber
2016-06-29  9:28 ` Arturo Borrero Gonzalez
2016-06-29 18:48 rodanber
2016-06-29 22:15 ` Roberto García
2016-07-01 14:17   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=001bc6b7-7d4f-5cea-5761-00143d4accdd@gmail.com \
    --to=rodanber@gmail.com \
    --cc=arturo.borrero.glez@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.