From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] ARM: perf/oprofile: fix off-by-one in stack check
Date: Wed, 9 Feb 2011 10:10:42 -0000 [thread overview]
Message-ID: <001c01cbc841$9c1d33a0$d4579ae0$@deacon@arm.com> (raw)
In-Reply-To: <1297223767-12827-1-git-send-email-rabin.vincent@stericsson.com>
Hi Rabin,
> Since tail is the previous fp - 1, we need to compare the new fp with tail + 1
> to ensure that we don't end up passing in the same tail again, in order to
> avoid a potential infinite loop in the perf interrupt handler (which has been
> observed to occur). A similar fix seems to be needed in the OProfile code.
>
> Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
> ---
> v2: refined check as per Will's comment
>
> arch/arm/kernel/perf_event.c | 2 +-
> arch/arm/oprofile/common.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Looks good, thanks.
Acked-by: Will Deacon <will.deacon@arm.com>
Will
prev parent reply other threads:[~2011-02-09 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 4:16 [PATCH] ARM: perf/oprofile: fix off-by-one in stack check Rabin Vincent
2011-02-08 15:57 ` Will Deacon
2011-02-09 3:56 ` [PATCHv2] " Rabin Vincent
2011-02-09 10:10 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001c01cbc841$9c1d33a0$d4579ae0$@deacon@arm.com' \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.