From: Seungwon Jeon <tgih.jun@samsung.com>
To: linux-mmc@vger.kernel.org
Cc: 'Chris Ball' <cjb@laptop.org>,
'Will Newton' <will.newton@imgtec.com>,
'James Hogan' <james.hogan@imgtec.com>,
'Jaehoon Chung' <jh80.chung@samsung.com>
Subject: [PATCH 2/2] mmc: dw_mmc: make sure of clearing HLE interrupt
Date: Wed, 28 Nov 2012 19:26:58 +0900 [thread overview]
Message-ID: <001c01cdcd52$e58a2260$b09e6720$%jun@samsung.com> (raw)
In-Reply-To:
Even though HLE interrupt is enabled, there is no touch.
This patch clears HLE interrupt which is not unhandled.
Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
---
drivers/mmc/host/dw_mmc.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 6785d62..b6db0ae 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -1009,6 +1009,11 @@ static void dw_mci_tasklet_func(unsigned long priv)
state = host->state;
data = host->data;
+ if (host->cmd_status & SDMMC_INT_HLE) {
+ dev_err(host->dev, "hardware locked write error\n");
+ goto unlock;
+ }
+
do {
prev_state = state;
@@ -1577,6 +1582,12 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id)
if (!pending)
break;
+ if (pending & SDMMC_INT_HLE) {
+ mci_writel(host, RINTSTS, SDMMC_INT_HLE);
+ host->cmd_status = pending;
+ tasklet_schedule(&host->tasklet);
+ }
+
if (pending & DW_MCI_CMD_ERROR_FLAGS) {
mci_writel(host, RINTSTS, DW_MCI_CMD_ERROR_FLAGS);
host->cmd_status = pending;
--
1.7.0.4
next reply other threads:[~2012-11-28 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 10:26 Seungwon Jeon [this message]
2012-11-28 10:45 ` [PATCH 2/2] mmc: dw_mmc: make sure of clearing HLE interrupt James Hogan
2012-11-29 7:35 ` Seungwon Jeon
2012-11-29 14:59 ` Jae hoon Chung
2012-11-30 11:49 ` Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001c01cdcd52$e58a2260$b09e6720$%jun@samsung.com' \
--to=tgih.jun@samsung.com \
--cc=cjb@laptop.org \
--cc=james.hogan@imgtec.com \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.