From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: perf: split up perf_event.c by architecture
Date: Tue, 23 Nov 2010 14:38:39 -0000 [thread overview]
Message-ID: <001f01cb8b1c$1ebf4db0$5c3de910$@deacon@arm.com> (raw)
In-Reply-To: <AANLkTimHOash3PoQgoosbifjUqxF+39w_hdMK1v_S-Ew@mail.gmail.com>
Hi Jean,
> About the patch 5/5:
>
> This probably is nitpicking from my side, but there still are warnings
> generated by checkpatch:
>
> WARNING: please, no space before tabs
> #3999: FILE: arch/arm/kernel/perf_event_xscale.c:9:
> + * ^I- xscale1pmu: 2 event counters and a cycle counter$
>
> WARNING: please, no space before tabs
> #4000: FILE: arch/arm/kernel/perf_event_xscale.c:10:
> + * ^I- xscale2pmu: 4 event counters and a cycle counter$
>
> total: 0 errors, 2 warnings, 4754 lines checked
These are in comments though so I'm not sure the coding-style rules
apply. I can change it if if *really* annoys you though :)
> Other than that, nice work!
>
> Acked-by: Jean Pihet <j-pihet@ti.com>
Great, thanks! The hard part is going to be getting this merged
without breaking any pending patches to perf_event.c. I think we're
alright at the moment for 2.6.38 but if you see any patches getting
scheduled that touch the old code, please let me know.
Will
next prev parent reply other threads:[~2010-11-23 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <-6296264039105571970@unknownmsgid>
2010-11-23 14:26 ` [PATCH v2] ARM: perf: split up perf_event.c by architecture Jean Pihet
2010-11-23 14:38 ` Will Deacon [this message]
[not found] ` <8976531311637671749@unknownmsgid>
2010-11-23 15:05 ` Jean Pihet
2010-11-22 16:38 Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001f01cb8b1c$1ebf4db0$5c3de910$@deacon@arm.com' \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.