From: Stefan Wahren <stefan.wahren@i2se.com>
To: Umang Jain <umang.jain@ideasonboard.com>,
linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v2] staging: vc04_services: vchiq_bus: Do not kfree device
Date: Thu, 19 Oct 2023 20:18:58 +0200 [thread overview]
Message-ID: <0020ed1e-9a89-4c63-a3a2-4c506ba33865@i2se.com> (raw)
In-Reply-To: <20231018055228.825524-1-umang.jain@ideasonboard.com>
Am 18.10.23 um 07:52 schrieb Umang Jain:
> As per device_register() documentation, this kfree() on error path will
> crash. The call to put_device() is all that is needed here to free the
> memory.
>
> Fixes: 027e5703de6b ("staging: vc04_services: vchiq_arm: Add new bus type and device type")
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>
next prev parent reply other threads:[~2023-10-19 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 5:52 [PATCH v2] staging: vc04_services: vchiq_bus: Do not kfree device Umang Jain
2023-10-19 18:18 ` Stefan Wahren [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-09 10:47 Umang Jain
2023-10-15 16:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0020ed1e-9a89-4c63-a3a2-4c506ba33865@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.