From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] arm: Convert v7 proc infos into a common macro
Date: Fri, 20 May 2011 15:31:42 +0100 [thread overview]
Message-ID: <002101cc16fa$a3bc6650$eb3532f0$@deacon@arm.com> (raw)
In-Reply-To: <1305898769-10462-1-git-send-email-pawel.moll@arm.com>
Hello Pawel,
> diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
> index babfba0..e5087aa 100644
> --- a/arch/arm/mm/proc-v7.S
> +++ b/arch/arm/mm/proc-v7.S
> @@ -436,33 +436,36 @@ cpu_elf_name:
>
> .section ".proc.info.init", #alloc, #execinstr
>
> - .type __v7_ca9mp_proc_info, #object
> -__v7_ca9mp_proc_info:
> - .long 0x410fc090 @ Required ID value
> - .long 0xff0ffff0 @ Mask for ID
> - ALT_SMP(.long \
> - PMD_TYPE_SECT | \
> - PMD_SECT_AP_WRITE | \
> - PMD_SECT_AP_READ | \
> - PMD_FLAGS_SMP)
> - ALT_UP(.long \
> - PMD_TYPE_SECT | \
> - PMD_SECT_AP_WRITE | \
> - PMD_SECT_AP_READ | \
> - PMD_FLAGS_UP)
> - .long PMD_TYPE_SECT | \
> - PMD_SECT_XN | \
> - PMD_SECT_AP_WRITE | \
> - PMD_SECT_AP_READ
> - W(b) __v7_ca9mp_setup
> + /*
> + * Standard v7 proc info content
> + */
> +.macro __v7_proc initfunc, mm_mmuflags = 0, io_mmuflags = 0, hwcaps = 0
> + ALT_SMP(.long PMD_TYPE_SECT | PMD_SECT_AP_WRITE | PMD_SECT_AP_READ | \
> + PMD_FLAGS_SMP | \mm_mmuflags)
> + ALT_UP(.long PMD_TYPE_SECT | PMD_SECT_AP_WRITE | PMD_SECT_AP_READ | \
> + PMD_FLAGS_UP | \mm_mmuflags)
My only minor gripe is the reformatting of the PMD_* here.
Functionally, it looks fine.
Acked-by: Will Deacon <will.deacon@arm.com>
Will
prev parent reply other threads:[~2011-05-20 14:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 16:49 [PATCH] arm: Add Cortex A5 proc_info Pawel Moll
2011-05-18 9:47 ` Pawel Moll
2011-05-18 10:53 ` Dave Martin
2011-05-18 12:06 ` Pawel Moll
2011-05-18 16:44 ` [PATCH v2] arm: Add Cortex A5 proc info Pawel Moll
2011-05-19 14:10 ` Will Deacon
2011-05-19 15:31 ` Pawel Moll
2011-05-19 16:08 ` Dave Martin
2011-05-20 9:14 ` Will Deacon
2011-05-20 11:51 ` Pawel Moll
2011-05-20 13:39 ` [PATCH v3 1/2] arm: Convert v7 proc infos into a common macro Pawel Moll
2011-05-20 13:39 ` [PATCH v3 2/2] arm: Add Cortex A5 proc info Pawel Moll
2011-05-20 14:32 ` Will Deacon
2011-05-20 14:31 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002101cc16fa$a3bc6650$eb3532f0$@deacon@arm.com' \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.