RE: [PATCH 1/2] dt-bindings: media: Add bindings for imx334

[<martinax.krasteva@linux.intel.com>]

Hi Rob,

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Friday, November 20, 2020 8:59 PM
> To: Martina Krasteva <martinax.krasteva@linux.intel.com>
> Cc: linux-media@vger.kernel.org; robh+dt@kernel.org; mchehab@kernel.org;
> devicetree@vger.kernel.org; daniele.alessandrelli@linux.intel.com;
> gjorgjix.rosikopulos@linux.intel.com; sakari.ailus@linux.intel.com
> Subject: Re: [PATCH 1/2] dt-bindings: media: Add bindings for imx334
> 
> On Fri, 20 Nov 2020 14:28:02 +0000, Martina Krasteva wrote:
> > From: Martina Krasteva <martinax.krasteva@intel.com>
> >
> > - Add dt-bindings documentation for Sony imx334 sensor driver.
> > - Add MAINTAINERS entry for Sony imx334 binding documentation.
> >
> > Signed-off-by: Martina Krasteva <martinax.krasteva@intel.com>
> > Reviewed-by: Gjorgji Rosikopulos <gjorgjix.rosikopulos@intel.com>
> > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
> > ---
> >  .../devicetree/bindings/media/i2c/sony,imx334.yaml | 59
> ++++++++++++++++++++++
> >  MAINTAINERS                                        |  7 +++
> >  2 files changed, 66 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> >
> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml:34:15:
> [warning] wrong indentation: expected 12 but found 14 (indentation)
> ./Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml:36:15:
> [warning] wrong indentation: expected 12 but found 14 (indentation)
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml:
> 'additionalProperties' is a required property
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml:
> ignoring, error in schema:
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> 
> 
> See https://patchwork.ozlabs.org/patch/1403740
> 
> The base for the patch is generally the last rc1. Any dependencies should
be
> noted.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.

Thank you, I will fix these warnings in the next version

Best Regards,
Martina