From: "Sricharan" <sricharan@codeaurora.org>
To: 'Wolfram Sang' <wsa@the-dreams.de>
Cc: devicetree@vger.kernel.org, architt@codeaurora.org,
linux-arm-msm@vger.kernel.org, ntelkar@codeaurora.org,
galak@codeaurora.org, linux-kernel@vger.kernel.org,
andy.gross@linaro.org, linux-i2c@vger.kernel.org,
iivanov@mm-sol.com, agross@codeaurora.org,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
nkaje@codeaurora.org
Subject: RE: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling
Date: Mon, 16 May 2016 11:29:25 +0530 [thread overview]
Message-ID: <002201d1af38$1eb3e330$5c1ba990$@codeaurora.org> (raw)
In-Reply-To: <20160513115021.GK1778@katana>
Hi,
> > > Among the bus errors reported from the QUP_MASTER_STATUS register
> > > only NACK is considered and transfer gets suspended, while other
> > > errors are ignored. Correct this and suspend the transfer for other
> > > errors as well. This avoids unnessecary 'timeouts' which happens
> > > when waiting for events that would never happen when there is
> > > already an error condition on the bus.
> > >
> > > Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> > > Reviewed-by: Andy Gross <andy.gross@linaro.org>
> >
> > Please check Documentation/i2c/fault-codes for proper fault codes.
>
Ok, Thanks for pointing this out. So, for NACK I think it is more
appropriate to
return -ENXIO and -EIO for other errors. Will correct this.
> And while we are here: NACK is not an error but a valid response. Can you
> remove the dev_err related to that? Otherwise tools like i2cdetect will
> probably flood your log.
Ok, will correct this.
Regards,
Sricharan
WARNING: multiple messages have this Message-ID (diff)
From: sricharan@codeaurora.org (Sricharan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling
Date: Mon, 16 May 2016 11:29:25 +0530 [thread overview]
Message-ID: <002201d1af38$1eb3e330$5c1ba990$@codeaurora.org> (raw)
In-Reply-To: <20160513115021.GK1778@katana>
Hi,
> > > Among the bus errors reported from the QUP_MASTER_STATUS register
> > > only NACK is considered and transfer gets suspended, while other
> > > errors are ignored. Correct this and suspend the transfer for other
> > > errors as well. This avoids unnessecary 'timeouts' which happens
> > > when waiting for events that would never happen when there is
> > > already an error condition on the bus.
> > >
> > > Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> > > Reviewed-by: Andy Gross <andy.gross@linaro.org>
> >
> > Please check Documentation/i2c/fault-codes for proper fault codes.
>
Ok, Thanks for pointing this out. So, for NACK I think it is more
appropriate to
return -ENXIO and -EIO for other errors. Will correct this.
> And while we are here: NACK is not an error but a valid response. Can you
> remove the dev_err related to that? Otherwise tools like i2cdetect will
> probably flood your log.
Ok, will correct this.
Regards,
Sricharan
WARNING: multiple messages have this Message-ID (diff)
From: "Sricharan" <sricharan@codeaurora.org>
To: "'Wolfram Sang'" <wsa@the-dreams.de>
Cc: <devicetree@vger.kernel.org>, <architt@codeaurora.org>,
<linux-arm-msm@vger.kernel.org>, <ntelkar@codeaurora.org>,
<galak@codeaurora.org>, <linux-kernel@vger.kernel.org>,
<andy.gross@linaro.org>, <linux-i2c@vger.kernel.org>,
<iivanov@mm-sol.com>, <agross@codeaurora.org>,
<dmaengine@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <nkaje@codeaurora.org>
Subject: RE: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling
Date: Mon, 16 May 2016 11:29:25 +0530 [thread overview]
Message-ID: <002201d1af38$1eb3e330$5c1ba990$@codeaurora.org> (raw)
In-Reply-To: <20160513115021.GK1778@katana>
Hi,
> > > Among the bus errors reported from the QUP_MASTER_STATUS register
> > > only NACK is considered and transfer gets suspended, while other
> > > errors are ignored. Correct this and suspend the transfer for other
> > > errors as well. This avoids unnessecary 'timeouts' which happens
> > > when waiting for events that would never happen when there is
> > > already an error condition on the bus.
> > >
> > > Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> > > Reviewed-by: Andy Gross <andy.gross@linaro.org>
> >
> > Please check Documentation/i2c/fault-codes for proper fault codes.
>
Ok, Thanks for pointing this out. So, for NACK I think it is more
appropriate to
return -ENXIO and -EIO for other errors. Will correct this.
> And while we are here: NACK is not an error but a valid response. Can you
> remove the dev_err related to that? Otherwise tools like i2cdetect will
> probably flood your log.
Ok, will correct this.
Regards,
Sricharan
next prev parent reply other threads:[~2016-05-16 5:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 11:31 [PATCH V2 0/2] drivers: i2c: qup: Some misc fixes Sricharan R
2016-05-06 11:31 ` Sricharan R
2016-05-06 11:31 ` [PATCH V2 1/2] drivers: i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled Sricharan R
2016-05-06 11:31 ` Sricharan R
2016-05-06 17:36 ` [V2, " Naveen Kaje
2016-05-06 17:36 ` Naveen Kaje
2016-05-13 11:47 ` [PATCH V2 " Wolfram Sang
2016-05-13 11:47 ` Wolfram Sang
2016-05-16 5:19 ` Sricharan
2016-05-16 5:19 ` Sricharan
2016-05-16 5:19 ` Sricharan
2016-05-06 11:31 ` [PATCH V2 2/2] drivers: i2c: qup: Fix error handling Sricharan R
2016-05-06 11:31 ` Sricharan R
2016-05-06 17:53 ` [V2,2/2] " Naveen Kaje
2016-05-06 17:53 ` Naveen Kaje
[not found] ` <1462534274-28925-3-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-05-13 11:48 ` [PATCH V2 2/2] " Wolfram Sang
2016-05-13 11:48 ` Wolfram Sang
2016-05-13 11:48 ` Wolfram Sang
2016-05-13 11:50 ` Wolfram Sang
2016-05-13 11:50 ` Wolfram Sang
2016-05-13 11:50 ` Wolfram Sang
2016-05-16 5:59 ` Sricharan [this message]
2016-05-16 5:59 ` Sricharan
2016-05-16 5:59 ` Sricharan
2016-05-13 11:44 ` [PATCH V2 0/2] drivers: i2c: qup: Some misc fixes Wolfram Sang
2016-05-13 11:44 ` Wolfram Sang
2016-05-16 5:13 ` Sricharan
2016-05-16 5:13 ` Sricharan
2016-05-16 5:13 ` Sricharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002201d1af38$1eb3e330$5c1ba990$@codeaurora.org' \
--to=sricharan@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nkaje@codeaurora.org \
--cc=ntelkar@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.