From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40136 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PhdZj-00089L-D9
	for qemu-devel@nongnu.org; Tue, 25 Jan 2011 02:44:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1PhdZh-0006I7-Ox
	for qemu-devel@nongnu.org; Tue, 25 Jan 2011 02:44:27 -0500
Received: from smtp.ispras.ru ([83.149.198.201]:50961)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1PhdZh-0006Hx-HI
	for qemu-devel@nongnu.org; Tue, 25 Jan 2011 02:44:25 -0500
From: "Pavel Dovgaluk" <Pavel.Dovgaluk@ispras.ru>
References: <001a01cbbbd2$5e0a4a10$1a1ede30$@Dovgaluk@ispras.ru>
	<4D3DB2A8.1010002@weilnetz.de>
In-Reply-To: <4D3DB2A8.1010002@weilnetz.de>
Subject: RE: [Qemu-devel] [PATCH] Correct win32 timers deleting
Date: Tue, 25 Jan 2011 10:43:16 +0300
Message-ID: <002701cbbc63$8753ee80$95fbcb80$@Dovgaluk@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Language: ru
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Stefan Weil' <Stefan.Weil@weilnetz.de>
Cc: qemu-devel@nongnu.org


> > diff --git a/qemu-timer.c b/qemu-timer.c index 95814af..548f2e5
> 100644
> > --- a/qemu-timer.c
> > +++ b/qemu-timer.c
> > @@ -972,7 +972,10 @@ static int win32_start_timer(struct
> qemu_alarm_timer
> > *t)
> 
> Your patch is broken here.

 I checked the patch file, my "sent items" folder in outlook. This line is
not broken in both places.
 But when I receive my patch from "qemu-devel" list, this line is broken.
 Do you have any ideas about that?

> 
> > - timeKillEvent(data->timerId);
> > - timeEndPeriod(data->period);
> > + if (data->timerId)
> > + timeKillEvent(data->timerId);
> > + if (data->period)
> > + timeEndPeriod(data->period);
> 
> CODING_STYLE requires {} for both if statements.

 Ok, inserted in new version.

> 
> Please check your patch using scripts/checkpatch.pl.
> 

 Now this script says, that patch is ok.


Pavel Dovgaluk