RE: Patch "USB: serial: mos7840: Supported MCS7810 device"

["Donald" <donald@asix.com.tw>]

Hi Alan,

Thank you for your reply. As for your comment regarding the LED feature flag, the driver can provide a flag parameter for LED
feature so that users will be able to set this LED feature at loading the driver, and by default, this flag is set false (LED
feature is disabled). Could you let me know if this is what exactly matches your comment?

Regards,
Donald

-----Original Message-----
From: Alan Cox [mailto:alan@lxorguk.ukuu.org.uk] 
Sent: Thursday, April 12, 2012 5:50 PM
To: Donald
Cc: 'Greg KH'; 'open list:USB SUBSYSTEM'; 'open list'
Subject: Re: Patch "USB: serial: mos7840: Supported MCS7810 device"

> +/* MCS7810 LED support */
> +#define MCS7810_HAS_LED

I would just enable this. Nobody is going to change it in their source code.


> +#ifdef MCS7810_HAS_LED
> +	/* Turn on MCS7810 LED */
> +	if (serial->num_ports == 1 && mos7840_port->mos7810_led_flag == 0) {

Same comment as before about leds and flags to indicate features.

All these if cases should be a feature flag of some kind

Alan