RE: [PATCH 0/2] arm: lpc32xx: restart: add support for soft reset

["Sylvain Lemieux" <slemieux.tyco@gmail.com>]

Hi Joachim,

> From: Joachim Eastwood [mailto:manabian@gmail.com]
> Sent: 18-Feb-16 5:08 PM
> To: slemieux.tyco@gmail.com
> 
> Hi Sylvain,
> 
> On 18 February 2016 at 22:35,  <slemieux.tyco@gmail.com> wrote:
> > From: Sylvain Lemieux <slemieux@tycoint.com>
> >
> > The LPC32xx provide the capability to perform a soft or hard reset;
> > a soft reset will no reset the external peripheral
> > (i.e. RESOUT_N output not asserted).
> >
> > The default behavior (i.e. hard reset) remain unchanged.
> >
> > Sylvain Lemieux (2):
> >   arm: lpc32xx: restart: add support for soft reset
> >   arm: lpc32xx: restart: support "cmd" from userspace
> >
> >  arch/arm/mach-lpc32xx/common.c | 26 +++++++++++++++++++++++---
> >  1 file changed, 23 insertions(+), 3 deletions(-)
> 
> Instead of adding more code to mach-lpc32xx could this code be moved
> to the watchdog driver (pnx4008_wdt.c) ?
> See register_restart_handler() and how it's used in other watchdog drivers.
> 
> Then maybe the restart hook in phy3250.c could be removed all together.

Thanks for the feedback;

It is possible to remove the "lpc23xx_restart" function from "mach-lpc32xx"
and add the functionality to the pnx4008 watchdog driver.
The restart hook in phy3250.c can be remove.

I will submit a new revision of the patch on Monday.

> 
I need to add a new functionality to the pnx4008 driver to 
keep the driver disable and only provide the restart hook.

I am planning to add the functionality using a module parameter;
this is the way the pnx833x & s3c2410 driver are doing it.

Do you have any feedback before a submit a patch for this change.

Sylvain Lemieux
> 
> regards,
> Joachim Eastwood