From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from z5.mailgun.us ([104.130.96.5]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXHMx-0000t1-GQ for ath10k@lists.infradead.org; Tue, 27 Oct 2020 05:18:04 +0000 From: "Rakesh Pillai" References: <20201020000506.1.Ifbc28707942179f1cefc7491e995814564495270@changeid> <001a01d6aa24$6ceaf390$46c0dab0$@codeaurora.org> In-Reply-To: Subject: RE: [PATCH] ath10k: add option for chip-id based BDF selection Date: Tue, 27 Oct 2020 10:47:54 +0530 Message-ID: <002801d6ac20$89ac4df0$9d04e9d0$@codeaurora.org> MIME-Version: 1.0 Content-Language: en-us List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: 'Doug Anderson' Cc: 'Abhishek Kumar' , 'Brian Norris' , 'linux-wireless' , 'LKML' , 'ath10k' , 'Kalle Valo' Cgo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gRnJvbTogRG91ZyBBbmRlcnNvbiA8ZGlh bmRlcnNAY2hyb21pdW0ub3JnPgo+IFNlbnQ6IFR1ZXNkYXksIE9jdG9iZXIgMjcsIDIwMjAgNDoy MSBBTQo+IFRvOiBSYWtlc2ggUGlsbGFpIDxwaWxsYWlyQGNvZGVhdXJvcmEub3JnPgo+IENjOiBB Ymhpc2hlayBLdW1hciA8a3VhYmhzQGNocm9taXVtLm9yZz47IEthbGxlIFZhbG8KPiA8a3ZhbG9A Y29kZWF1cm9yYS5vcmc+OyBhdGgxMGsgPGF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnPjsgTEtN TAo+IDxsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnPjsgbGludXgtd2lyZWxlc3MgPGxpbnV4 LQo+IHdpcmVsZXNzQHZnZXIua2VybmVsLm9yZz47IEJyaWFuIE5vcnJpcyA8YnJpYW5ub3JyaXNA Y2hyb21pdW0ub3JnPgo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGF0aDEwazogYWRkIG9wdGlvbiBm b3IgY2hpcC1pZCBiYXNlZCBCREYgc2VsZWN0aW9uCj4gCj4gSGksCj4gCj4gT24gU2F0LCBPY3Qg MjQsIDIwMjAgYXQgOTo0MCBBTSBSYWtlc2ggUGlsbGFpIDxwaWxsYWlyQGNvZGVhdXJvcmEub3Jn PiB3cm90ZToKPiA+Cj4gPiA+ICAgICAgICAgaWYgKGJkX2llX3R5cGUgPT0gQVRIMTBLX0JEX0lF X0JPQVJEKSB7Cj4gPiA+ICsgICAgICAgICAgICAgICAvKiBXaXRoIHZhcmlhbnQgYW5kIGNoaXAg aWQgKi8KPiA+ID4gICAgICAgICAgICAgICAgIHJldCA9IGF0aDEwa19jb3JlX2NyZWF0ZV9ib2Fy ZF9uYW1lKGFyLCBib2FyZG5hbWUsCj4gPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBzaXplb2YoYm9hcmRuYW1lKSwgdHJ1ZSk7Cj4gPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNpemVvZihib2Fy ZG5hbWUpLCB0cnVlLCB0cnVlKTsKPiA+Cj4gPiBJbnN0ZWFkIG9mIGFkZGluZyBhIGxvdCBvZiBj b2RlIHRvIGdlbmVyYXRlIGEgc2Vjb25kIGZhbGxiYWNrIG5hbWUsIGl0cwo+IGJldHRlciB0byBq dXN0IG1vZGlmeSB0aGUgY29uZGl0aW9uIGluc2lkZSB0aGUgZnVuY3Rpb24KPiDigJxhdGgxMGtf Y29yZV9jcmVhdGVfYm9hcmRfbmFtZeKAnSB0byBhbGxvdyB0aGUgZ2VuZXJhdGlvbiBvZiBCREYg dGFnIHVzaW5nCj4gY2hpcCBpZCwgZXZlbiDigJxpZiBhci0+aWQuYmRmX2V4dFswXSA9PSAnXDAg 4oCcLgo+ID4KPiA+IFRoaXMgd2lsbCBtYWtlIHN1cmUgdGhhdCB0aGUgdmFyaWFudCBzdHJpbmcg aXMgTlVMTCwgYW5kIGp1c3QgYm9hcmQtaWQgYW5kCj4gY2hpcC1pZCBpcyB1c2VkLiBUaGlzIHdp bGwgaGVscCBhdm9pZCBtb3N0IG9mIHRoZSBjb2RlIGNoYW5nZXMuCj4gPiBUaGUgY29kZSB3b3Vs ZCBsb29rIGFzIHNob3duIGJlbG93Cj4gPgo+ID4gQEAgLTE0OTMsNyArMTQ5Myw3IEBAIHN0YXRp YyBpbnQgYXRoMTBrX2NvcmVfY3JlYXRlX2JvYXJkX25hbWUoc3RydWN0Cj4gYXRoMTBrICphciwg Y2hhciAqbmFtZSwKPiA+ICAgICAgICAgfQo+ID4KPiA+ICAgICAgICAgaWYgKGFyLT5pZC5xbWlf aWRzX3ZhbGlkKSB7Cj4gPiAtICAgICAgICAgICAgICAgaWYgKHdpdGhfdmFyaWFudCAmJiBhci0+ aWQuYmRmX2V4dFswXSAhPSAnXDAnKQo+ID4gKyAgICAgICAgICAgICAgIGlmICh3aXRoX3Zhcmlh bnQpCj4gCj4gV291bGRuJ3QgdGhlIGFib3ZlIGp1c3QgYmUgImlmICh3aXRoX2NoaXBfaWQpIiBp bnN0ZWFkPyAgLi4uYnV0IHllYWgsCj4gdGhhdCB3b3VsZCBiZSBhIGNsZWFuZXIgd2F5IHRvIGRv IHRoaXMuICBBYmhpc2hlazogZG8geW91IHdhbnQgdG8gcG9zdAo+IGEgdjI/CgoKVGhlIHBhcmFt ZXRlciBuYW1lIHBhc3NlZCB0byB0aGlzIGZ1bmN0aW9uIGlzICJ3aXRoX3ZhcmlhbnQiLCBzaW5j ZSBvdGhlciBub24tcW1pIHRhcmdldHMgKGVnIFFDQTYxNzQpIHVzZSB0aGlzIGFzIGEgZmxhZyB0 byBqdXN0IGFkZCB0aGUgdmFyaWFudCBmaWVsZC4KVGhpcyBjYW4gYmUgcmVuYW1lZCB0byBzb21l dGhpbmcgbWVhbmluZ2Z1bCBmb3IgYm90aCBxbWkgYW5kIG5vbi1xbWkgdGFyZ2V0cy4KCj4gCj4g LURvdWcKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwph dGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C115C388F9 for ; Tue, 27 Oct 2020 05:18:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B01312084C for ; Tue, 27 Oct 2020 05:18:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="e+8+i9D6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505781AbgJ0FSD (ORCPT ); Tue, 27 Oct 2020 01:18:03 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:11788 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2505777AbgJ0FSD (ORCPT ); Tue, 27 Oct 2020 01:18:03 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1603775882; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Sender; bh=g64XdioYWzF68Lt5U5nrTtR7/oWlvIneDTTlwIVAqXc=; b=e+8+i9D6Fg92B8eBkmSAtiqJ4ujSthF5Wbym6TXtTrr6XcE9tluPVgrYpIjuPIwVuJ9lL1Se v983N8S6Q1FRBHtmaPoUV6FYSv1wqrQdfLPShXkruOuofgq67HH/H7NdecIcb8FDMQOfTrWV y9D7d8LYpr8dEn769yRdhbRivNQ= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 5f97ad895c97867acefbaa04 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 27 Oct 2020 05:18:01 GMT Sender: pillair=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B4440C433CB; Tue, 27 Oct 2020 05:18:01 +0000 (UTC) Received: from Pillair (unknown [49.205.247.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: pillair) by smtp.codeaurora.org (Postfix) with ESMTPSA id 23AE3C433C9; Tue, 27 Oct 2020 05:17:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 23AE3C433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=pillair@codeaurora.org From: "Rakesh Pillai" To: "'Doug Anderson'" Cc: "'Abhishek Kumar'" , "'Kalle Valo'" , "'ath10k'" , "'LKML'" , "'linux-wireless'" , "'Brian Norris'" References: <20201020000506.1.Ifbc28707942179f1cefc7491e995814564495270@changeid> <001a01d6aa24$6ceaf390$46c0dab0$@codeaurora.org> In-Reply-To: Subject: RE: [PATCH] ath10k: add option for chip-id based BDF selection Date: Tue, 27 Oct 2020 10:47:54 +0530 Message-ID: <002801d6ac20$89ac4df0$9d04e9d0$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFjEyTiGf73PRIYZgnn2adypkFjcAJI1HsxAfRirrsAqQquEAGWWD6uql40+ZA= Content-Language: en-us Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > -----Original Message----- > From: Doug Anderson > Sent: Tuesday, October 27, 2020 4:21 AM > To: Rakesh Pillai > Cc: Abhishek Kumar ; Kalle Valo > ; ath10k ; LKML > ; linux-wireless wireless@vger.kernel.org>; Brian Norris > Subject: Re: [PATCH] ath10k: add option for chip-id based BDF = selection >=20 > Hi, >=20 > On Sat, Oct 24, 2020 at 9:40 AM Rakesh Pillai = wrote: > > > > > if (bd_ie_type =3D=3D ATH10K_BD_IE_BOARD) { > > > + /* With variant and chip id */ > > > ret =3D ath10k_core_create_board_name(ar, = boardname, > > > - = sizeof(boardname), true); > > > + sizeof(boardname), = true, true); > > > > Instead of adding a lot of code to generate a second fallback name, = its > better to just modify the condition inside the function > =E2=80=9Cath10k_core_create_board_name=E2=80=9D to allow the = generation of BDF tag using > chip id, even =E2=80=9Cif ar->id.bdf_ext[0] =3D=3D '\0 =E2=80=9C. > > > > This will make sure that the variant string is NULL, and just = board-id and > chip-id is used. This will help avoid most of the code changes. > > The code would look as shown below > > > > @@ -1493,7 +1493,7 @@ static int = ath10k_core_create_board_name(struct > ath10k *ar, char *name, > > } > > > > if (ar->id.qmi_ids_valid) { > > - if (with_variant && ar->id.bdf_ext[0] !=3D '\0') > > + if (with_variant) >=20 > Wouldn't the above just be "if (with_chip_id)" instead? ...but yeah, > that would be a cleaner way to do this. Abhishek: do you want to post > a v2? The parameter name passed to this function is "with_variant", since = other non-qmi targets (eg QCA6174) use this as a flag to just add the = variant field. This can be renamed to something meaningful for both qmi and non-qmi = targets. >=20 > -Doug