From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hai Li" Subject: RE: drm/msm/dsi: hs_zero timing Date: Wed, 26 Aug 2015 13:49:47 -0400 Message-ID: <002a01d0e027$9aeb90a0$d0c2b1e0$@codeaurora.org> References: <3892D88DBE322D4FA4B7FE095FDA445A07C27BD1AD3D@seldmbx01.corpusers.net> <005401d0dc4b$6591db60$30b59220$@codeaurora.org> <3892D88DBE322D4FA4B7FE095FDA445A07C27BD1AD49@seldmbx01.corpusers.net> <03e301d0de79$b8975940$29c60bc0$@codeaurora.org> <001e01d0e014$b459dbe0$1d0d93a0$@codeaurora.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1441547321==" Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D28E7A12E for ; Wed, 26 Aug 2015 10:49:51 -0700 (PDT) In-Reply-To: Content-Language: en-us List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: 'Werner Johansson' Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is a multipart message in MIME format. --===============1441547321== Content-Type: multipart/alternative; boundary="----=_NextPart_000_002B_01D0E006.13DC61A0" Content-Language: en-us This is a multipart message in MIME format. ------=_NextPart_000_002B_01D0E006.13DC61A0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Thanks Werner to test it out. I will focus on the dphy timing = calculation then. =20 It=E2=80=99s better to avoid discussing the excel formula publicly. :) =20 =20 Thanks, Hai =20 From: Werner Johansson [mailto:werner.johansson@gmail.com]=20 Sent: Wednesday, August 26, 2015 1:39 PM To: Hai Li Cc: Rob Clark; werner.johansson@sonymobile.com; = dri-devel@lists.freedesktop.org Subject: RE: drm/msm/dsi: hs_zero timing =20 On Aug 26, 2015 08:34, "Hai Li" > wrote: > > Hi Werner, > > Thanks for sharing this. The DPHY timings in downstream dtsi are = exactly the same as the excel calculation, but slightly different from = the output of drm code as you posted. (e.g hs_zero is 116 vs 118) > I think it is caused by some precision loss during driver calculation, = but I need to double check. > > Could you help to try configuring the same DPHY timings as downstream, = but leave the values in DSIPHY_LNx_CFG4 as is, to see if it works? 116 to hs_zero works fine without any other changes (only 118 and every = eighth number up and down from there fails with this panel timing), so = if we can do something to make sure we hit a working value for hs_zero = without touching anything else that would be great!=20 Thanks for checking the timings and let me know if you want me to test = anything else. Is the excel formula considered public so we can discuss = it here?=20 /wj ------=_NextPart_000_002B_01D0E006.13DC61A0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Thanks Werner to test it out. I will focus on the dphy timing = calculation then.

 

It=E2=80=99s better to avoid discussing the excel formula publicly. = J

 

 

Thanks,

Hai

 

From:<= /b> = Werner Johansson [mailto:werner.johansson@gmail.com]
Sent: = Wednesday, August 26, 2015 1:39 PM
To: Hai Li
Cc: = Rob Clark; werner.johansson@sonymobile.com; = dri-devel@lists.freedesktop.org
Subject: RE: drm/msm/dsi: = hs_zero timing

 


On Aug 26, 2015 08:34, = "Hai Li" <hali@codeaurora.org> = wrote:
>
> Hi Werner,
>
> Thanks for sharing = this. The DPHY timings in downstream dtsi are exactly the same as the = excel calculation, but slightly different from the output of drm code as = you posted. (e.g hs_zero is 116 vs 118)
> I think it is caused by = some precision loss during driver calculation, but I need to double = check.
>
> Could you help to try configuring the same DPHY = timings as downstream, but leave the values in  DSIPHY_LNx_CFG4 as = is, to see if it works?

116 to hs_zero works fine = without any other changes (only 118 and every eighth number up and down = from there fails with this panel timing), so if we can do something to = make sure we hit a working value for hs_zero without touching anything = else that would be great!

Thanks for checking the = timings and let me know if you want me to test anything else. Is the = excel formula considered public so we can discuss it here? =

/wj

------=_NextPart_000_002B_01D0E006.13DC61A0-- --===============1441547321== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1441547321==--