From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B98BC433DF for ; Mon, 15 Jun 2020 10:00:57 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB6AE2068E for ; Mon, 15 Jun 2020 10:00:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dAhhjC9D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB6AE2068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jklv5-0002RG-1H; Mon, 15 Jun 2020 10:00:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jklv3-0002Qz-40 for xen-devel@lists.xenproject.org; Mon, 15 Jun 2020 10:00:45 +0000 X-Inumbo-ID: 11c752ea-aeef-11ea-b7bb-bc764e2007e4 Received: from mail-wr1-x443.google.com (unknown [2a00:1450:4864:20::443]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 11c752ea-aeef-11ea-b7bb-bc764e2007e4; Mon, 15 Jun 2020 10:00:41 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id q11so16456666wrp.3 for ; Mon, 15 Jun 2020 03:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=7FVvavwJRrtYZHpZPbhx3fXJrJ5Jws1zwwFYj2fs8rE=; b=dAhhjC9D6bGt5slqmC3gXs2TN8dkXW25+0L8bgrlyYwW5wA4gHFJsxIOWJChZAwbvo OMHmkTglUlxYxL6WTv4JFdJJ3GcgjIZXTOwSeXf+sl8WyyZvDgBwv4z0IGX19wR3CZTu fc6PqsleJcmpt4+Mjo+51VWIlwkpJVVy0jivAZ4sla6CX0OkffK/7BHzrQayl9AroqUg JQBn4ICBtEp2Bb05CSu3OQ9bqHvkSYXItNY3vhfczLSzBL2p9Nlzg8pM8bFPaPgfVpPl vJg1YAGREELtyddzd2DQYtlDWayDh5yxiFObfk8acvtl5HUN8S7M/+Pv1V4lKr0DUwdt SVJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=7FVvavwJRrtYZHpZPbhx3fXJrJ5Jws1zwwFYj2fs8rE=; b=GYjAAu2j8N/5CShgRijOlud+yj+r07cvKbRcgmz7KnUcycr+e4ljjE4+zGpJdjlOwT +B5vWt/vrN08R22Y9YtoxVwJMdeqW3y2R4S/OwPTYeMo3zF0/1nQbWLiJVPcQFUVf6JH 0Jva5O90J9+Jpp61ODH8WxlZuiXzxG2kRwf0TdS9duzdzhAw5aFHOXObsQHL1v9NBZ4m tZE/B9Qx8h5NlCFYbPxhiJq3W4ApNmMUcVosIjAzC0KtMkyaZwu4PTnGWGePTtLII1+w HT4kcGL+WpAMq4Du8O9uffdziuqX8Zuva+nNxuuyyAZJLrf6KZwNtil7rCJVDYt83DxZ qYNw== X-Gm-Message-State: AOAM533p8AW4XUmpsdzkRhPubJ5FWLsS4sbs3YJVovhJ/Sg+4kHKMxn4 5oVkfNDp26CdugI9OcJRiYo= X-Google-Smtp-Source: ABdhPJyFQ7nwu3Ca07xeA2Cv4O5oQ+DCZ/cJ0nIAe5qJTU/51EgphOOqRkHgMvGE05W9dNmpNdPPNQ== X-Received: by 2002:a5d:6789:: with SMTP id v9mr29908456wru.124.1592215240328; Mon, 15 Jun 2020 03:00:40 -0700 (PDT) Received: from CBGR90WXYV0 (54-240-197-234.amazon.com. [54.240.197.234]) by smtp.gmail.com with ESMTPSA id c206sm24337775wmf.36.2020.06.15.03.00.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jun 2020 03:00:39 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Roger Pau Monne'" , References: <20200612155640.4101-1-roger.pau@citrix.com> <20200612155640.4101-2-roger.pau@citrix.com> In-Reply-To: <20200612155640.4101-2-roger.pau@citrix.com> Subject: RE: [PATCH for-4.14 1/8] x86/hvm: fix vIO-APIC build without IRQ0_SPECIAL_ROUTING Date: Mon, 15 Jun 2020 11:00:38 +0100 Message-ID: <002b01d642fb$d2e229b0$78a67d10$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIx2gY8gI577+TutNP+VjieYU4/XgB3+NohqB6DL3A= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Andrew Cooper' , 'Wei Liu' , 'Jan Beulich' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Roger Pau Monne > Sent: 12 June 2020 16:57 > To: xen-devel@lists.xenproject.org > Cc: paul@xen.org; Roger Pau Monne ; Jan Beulich = ; Andrew > Cooper ; Wei Liu > Subject: [PATCH for-4.14 1/8] x86/hvm: fix vIO-APIC build without = IRQ0_SPECIAL_ROUTING >=20 > pit_channel0_enabled needs to be guarded with IRQ0_SPECIAL_ROUTING > since it's only used when the special handling of ISA IRQ 0 is = enabled. >=20 > No functional change. >=20 > Signed-off-by: Roger Pau Monn=C3=A9 > --- > xen/arch/x86/hvm/vioapic.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c > index b87facb0e0..bd41036137 100644 > --- a/xen/arch/x86/hvm/vioapic.c > +++ b/xen/arch/x86/hvm/vioapic.c > @@ -391,10 +391,12 @@ static void ioapic_inj_irq( > vlapic_set_irq(target, vector, trig_mode); > } >=20 > +#ifdef IRQ0_SPECIAL_ROUTING > static inline int pit_channel0_enabled(void) > { > return pt_active(¤t->domain->arch.vpit.pt0); > } > +#endif It's only called in two places. How about just manually inlining? Paul >=20 > static void vioapic_deliver(struct hvm_vioapic *vioapic, unsigned int = pin) > { > -- > 2.26.2