From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: RE: [PATCH 10/10] drm/exynos: added virtual display driver. Date: Thu, 15 Mar 2012 21:01:30 +0900 Message-ID: <002c01cd02a3$5b81a400$1284ec00$%dae@samsung.com> References: <002b01cd029f$d3eb4800$7bc1d800$%dae@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 726AA9EC29 for ; Thu, 15 Mar 2012 05:01:33 -0700 (PDT) Received: from epcpsbgm1.samsung.com (mailout2.samsung.com [203.254.224.25]) by mailout2.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0M0X00JSMDEACS40@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 15 Mar 2012 21:01:31 +0900 (KST) Received: from NOINKIDAE02 ([165.213.219.102]) by mmp1.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTPA id <0M0X002K4DELSJ90@mmp1.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 15 Mar 2012 21:01:33 +0900 (KST) In-reply-to: Content-language: ko List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: 'David Airlie' Cc: 'kyungmin park' , 'sw0312 kim' , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org > -----Original Message----- > From: David Airlie [mailto:airlied@redhat.com] > Sent: Thursday, March 15, 2012 8:44 PM > To: Inki Dae > Cc: kyungmin park; sw0312 kim; dri-devel@lists.freedesktop.org; Dave > Airlie > Subject: Re: [PATCH 10/10] drm/exynos: added virtual display driver. > > > > ----- Original Message ----- > > From: "Inki Dae" > > To: "Dave Airlie" > > Cc: "kyungmin park" , "sw0312 kim" > , > > dri-devel@lists.freedesktop.org > > Sent: Thursday, 15 March, 2012 11:36:14 AM > > Subject: RE: [PATCH 10/10] drm/exynos: added virtual display driver. > > > > > > > > > -----Original Message----- > > > From: Dave Airlie [mailto:airlied@gmail.com] > > > Sent: Thursday, March 15, 2012 7:44 PM > > > To: Inki Dae > > > Cc: dri-devel@lists.freedesktop.org; kyungmin.park@samsung.com; > > > sw0312.kim@samsung.com > > > Subject: Re: [PATCH 10/10] drm/exynos: added virtual display > > > driver. > > > > > > > diff --git a/include/drm/exynos_drm.h b/include/drm/exynos_drm.h > > > > index 907daaf..1123342 100644 > > > > --- a/include/drm/exynos_drm.h > > > > +++ b/include/drm/exynos_drm.h > > > > @@ -76,6 +76,22 @@ struct drm_exynos_gem_mmap { > > > > uint64_t mapped; > > > > }; > > > > > > > > +/** > > > > + * A structure for user connection request of virtual display. > > > > + * > > > > + * @connection: indicate whether doing connetion or not by user. > > > > + * @extensions: if this value is 1 then the vidi driver would > > > > need > > > additional > > > > + * 128bytes edid data. > > > > + * @pad: just padding to be 64-bit aligned. > > > > + * @edid: the edid data pointer from user side. > > > > + */ > > > > +struct drm_exynos_vidi_connection { > > > > + unsigned int connection; > > > > + unsigned int extensions; > > > > + unsigned int pad; > > > > + void *edid; > > > > +}; > > > > + > > > > > > No void * in ioctl structs use u64, also not sure why you have a > > > 32-bit pad since you probably want it padded to 64-bit. > > > > > > Dave. > > > > Yes, right. I wanted it to be padded to 64-bit. and edid would point > > to > > buffer containing edit data and it would be passed from user to > > kernel side > > so for this, is it right to use u64? I will change variable type to > > "void > > __user *" if your missing point. please let me know if there is any > > problem. > > > > You need to use __u64 instead of a void, since void * isn't a fixed length > across 32/64-bit. > > You'll notice this done a few places in the drm kms interfaces. > > Dave. Ok, got it. thanks for your comment. Inki Dae