From: Paul Durrant <xadimgnik@gmail.com>
To: "'Ian Jackson'" <ian.jackson@citrix.com>,
"'Nick Rosbrook'" <rosbrookn@gmail.com>
Cc: 'Nick Rosbrook' <rosbrookn@ainfosec.com>,
xen-devel@lists.xenproject.org,
'George Dunlap' <George.Dunlap@citrix.com>,
'Wei Liu' <wl@xen.org>
Subject: RE: [PATCH for-4.14] tools: check go compiler version if present
Date: Mon, 15 Jun 2020 15:46:10 +0100 [thread overview]
Message-ID: <002e01d64323$b64bddf0$22e399d0$@xen.org> (raw)
In-Reply-To: <24295.35026.88022.957662@mariner.uk.xensource.com>
> -----Original Message-----
> From: Ian Jackson <ian.jackson@citrix.com>
> Sent: 15 June 2020 15:42
> To: Nick Rosbrook <rosbrookn@gmail.com>
> Cc: xen-devel@lists.xenproject.org; paul@xen.org; George Dunlap <George.Dunlap@citrix.com>; Nick
> Rosbrook <rosbrookn@ainfosec.com>; Wei Liu <wl@xen.org>
> Subject: Re: [PATCH for-4.14] tools: check go compiler version if present
>
> Nick Rosbrook writes ("Re: [PATCH for-4.14] tools: check go compiler version if present"):
> > > Ideally at some point maybe we would make this clearer but not now.
> >
> > Okay, sounds good.
> >
> > > Have you tested the situations you describe ? That might be a better
> > > way of checking that it's right than the code inspection which is
> > > obviously failing for me now...
> >
> > Yes, I have tested the following situations:
> >
> > (1) ./configure without go installed => go is not enabled
> > (2) ./configure with go version < 1.11.1 => go is not enabled
> > (3) ./configure with go version > 1.11.1 => go is enabled
> > (4) ./configure --enable-golang without go installed => error
> > (5) ./configure --enable-golang with go < 1.11.1 => error
> > (6) ./configure --disable-golang in any case => go is not enabled
>
> Thorough!
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> Paul, this should go into 4.14. Can I have a release ack plase ?
You may...
Release-acked-by: Paul Durrant <paul@xen.org>
>
> Thanks,
> Ian.
next prev parent reply other threads:[~2020-06-15 14:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 14:31 [PATCH for-4.14] tools: check go compiler version if present Nick Rosbrook
2020-06-12 16:40 ` Ian Jackson
2020-06-12 21:50 ` Nick Rosbrook
2020-06-15 13:48 ` Ian Jackson
2020-06-15 14:32 ` Nick Rosbrook
2020-06-15 14:42 ` Ian Jackson
2020-06-15 14:46 ` Paul Durrant [this message]
2020-06-15 14:50 ` Ian Jackson
2020-06-15 11:42 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002e01d64323$b64bddf0$22e399d0$@xen.org' \
--to=xadimgnik@gmail.com \
--cc=George.Dunlap@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=paul@xen.org \
--cc=rosbrookn@ainfosec.com \
--cc=rosbrookn@gmail.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.