All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joachim Wiberg <troglobit@gmail.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 4/5] package/inadyn: refactor start script
Date: Sun, 5 Dec 2021 08:56:20 +0100	[thread overview]
Message-ID: <002ef1ea-f890-e812-e677-ee9a3787cc3b@gmail.com> (raw)
In-Reply-To: <20211204231509.2507f151@windsurf>


[-- Attachment #1.1.1: Type: text/plain, Size: 952 bytes --]

Hi Thomas!

On 12/4/21 11:15 PM, Thomas Petazzoni wrote:
> On Mon, 22 Nov 2021 03:08:03 +0100
> Joachim Wiberg <troglobit@gmail.com> wrote:
>> This patch is a complete rewrite of the start script, reducing code
>> duplication by using a helper cmd() function and adding support for:
>> [snip]
> Actually, for init script, we are now trying to use a common style and
> construction for all, based on package/busybox/S01syslogd.

Ah, I was actually wondering about that, couldn't find any info on it
though.

> We don't want each init script of each package to be its own creative
> work of art, but instead we prefer consistency.
Understandable.  That's good policy actually.

> It would actually be good to document this in the Buildroot manual.

I'll see if I can whip something up :)

> Could you try to rework your init script according to
> package/busybox/S01syslogd ?

Sure, no problem!


Best regards
 /Joachim



[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-12-05  7:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22  2:07 [Buildroot] [PATCH 0/5] package/inadyn: bump version, script refactor, etc Joachim Wiberg
2021-11-22  2:08 ` [Buildroot] [PATCH 1/5] package/inadyn: bump to version 2.9.0 Joachim Wiberg
2021-12-04 22:13   ` Thomas Petazzoni
2021-11-22  2:08 ` [Buildroot] [PATCH 2/5] DEVELOPERS: add Joachim Wiberg as maintainer for inadyn Joachim Wiberg
2021-12-04 22:12   ` Thomas Petazzoni
2021-11-22  2:08 ` [Buildroot] [PATCH 3/5] package/inadyn: replace local systemd unit file with upstream Joachim Wiberg
2021-12-04 22:13   ` Thomas Petazzoni
2021-11-22  2:08 ` [Buildroot] [PATCH 4/5] package/inadyn: refactor start script Joachim Wiberg
2021-12-04 22:15   ` Thomas Petazzoni
2021-12-05  7:56     ` Joachim Wiberg [this message]
2021-11-22  2:08 ` [Buildroot] [PATCH 5/5] package/inadyn: update inadyn.conf example Joachim Wiberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=002ef1ea-f890-e812-e677-ee9a3787cc3b@gmail.com \
    --to=troglobit@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.