From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from linode.aoot.com (linode.aoot.com [69.164.194.13]) by ml01.01.org (Postfix) with ESMTP id 11AB021A04830 for ; Wed, 5 Apr 2017 08:43:40 -0700 (PDT) From: "Steve Wise" References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> In-Reply-To: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Subject: RE: [RFC 4/8] p2pmem: Add debugfs "stats" file Date: Wed, 5 Apr 2017 10:43:38 -0500 Message-ID: <003201d2ae23$6527ef10$2f77cd30$@opengridcomputing.com> MIME-Version: 1.0 Content-Language: en-us List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: 'Sagi Grimberg' , 'Logan Gunthorpe' , 'Christoph Hellwig' , "'James E.J. Bottomley'" , "'Martin K. Petersen'" , 'Jens Axboe' , 'Stephen Bates' , 'Max Gurtovoy' , 'Dan Williams' , 'Keith Busch' , 'Jason Gunthorpe' Cc: linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org List-ID: > > > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > > + if (!p2pmem_debugfs_root) > > + pr_info("could not create debugfs entry, continuing\n"); > > + > > Why continue? I think it'd be better to just fail it. > Because not having debugfs support isn't fatal to using p2pmem. So I believe it is better to continue. But this is trivial, IMO, so either was is ok with me. > Besides, this can be safely squashed into patch 1. Yes. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: swise@opengridcomputing.com (Steve Wise) Date: Wed, 5 Apr 2017 10:43:38 -0500 Subject: [RFC 4/8] p2pmem: Add debugfs "stats" file In-Reply-To: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Message-ID: <003201d2ae23$6527ef10$2f77cd30$@opengridcomputing.com> > > > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > > + if (!p2pmem_debugfs_root) > > + pr_info("could not create debugfs entry, continuing\n"); > > + > > Why continue? I think it'd be better to just fail it. > Because not having debugfs support isn't fatal to using p2pmem. So I believe it is better to continue. But this is trivial, IMO, so either was is ok with me. > Besides, this can be safely squashed into patch 1. Yes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Steve Wise" To: "'Sagi Grimberg'" , "'Logan Gunthorpe'" , "'Christoph Hellwig'" , "'James E.J. Bottomley'" , "'Martin K. Petersen'" , "'Jens Axboe'" , "'Stephen Bates'" , "'Max Gurtovoy'" , "'Dan Williams'" , "'Keith Busch'" , "'Jason Gunthorpe'" Cc: , , , , , References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> In-Reply-To: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Subject: RE: [RFC 4/8] p2pmem: Add debugfs "stats" file Date: Wed, 5 Apr 2017 10:43:38 -0500 Message-ID: <003201d2ae23$6527ef10$2f77cd30$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: > > > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > > + if (!p2pmem_debugfs_root) > > + pr_info("could not create debugfs entry, continuing\n"); > > + > > Why continue? I think it'd be better to just fail it. > Because not having debugfs support isn't fatal to using p2pmem. So I believe it is better to continue. But this is trivial, IMO, so either was is ok with me. > Besides, this can be safely squashed into patch 1. Yes. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [RFC 4/8] p2pmem: Add debugfs "stats" file Date: Wed, 5 Apr 2017 10:43:38 -0500 Message-ID: <003201d2ae23$6527ef10$2f77cd30$@opengridcomputing.com> References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <95928b70-0148-7297-8f5e-5031d996bb98-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> Content-Language: en-us List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: 'Sagi Grimberg' , 'Logan Gunthorpe' , 'Christoph Hellwig' , "'James E.J. Bottomley'" , "'Martin K. Petersen'" , 'Jens Axboe' , 'Stephen Bates' , 'Max Gurtovoy' , 'Dan Williams' , 'Keith Busch' , 'Jason Gunthorpe' Cc: linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rdma@vger.kernel.org > > > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > > + if (!p2pmem_debugfs_root) > > + pr_info("could not create debugfs entry, continuing\n"); > > + > > Why continue? I think it'd be better to just fail it. > Because not having debugfs support isn't fatal to using p2pmem. So I believe it is better to continue. But this is trivial, IMO, so either was is ok with me. > Besides, this can be safely squashed into patch 1. Yes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754821AbdDEQLr (ORCPT ); Wed, 5 Apr 2017 12:11:47 -0400 Received: from linode.aoot.com ([69.164.194.13]:51008 "EHLO linode.aoot.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754490AbdDEQLB (ORCPT ); Wed, 5 Apr 2017 12:11:01 -0400 From: "Steve Wise" To: "'Sagi Grimberg'" , "'Logan Gunthorpe'" , "'Christoph Hellwig'" , "'James E.J. Bottomley'" , "'Martin K. Petersen'" , "'Jens Axboe'" , "'Stephen Bates'" , "'Max Gurtovoy'" , "'Dan Williams'" , "'Keith Busch'" , "'Jason Gunthorpe'" Cc: , , , , , References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> In-Reply-To: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Subject: RE: [RFC 4/8] p2pmem: Add debugfs "stats" file Date: Wed, 5 Apr 2017 10:43:38 -0500 Message-ID: <003201d2ae23$6527ef10$2f77cd30$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGDrzFnHJRLFLPPZsE1XDlAT9YfwAF3pSaXAlTGZmeiNoS5cA== Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > > + if (!p2pmem_debugfs_root) > > + pr_info("could not create debugfs entry, continuing\n"); > > + > > Why continue? I think it'd be better to just fail it. > Because not having debugfs support isn't fatal to using p2pmem. So I believe it is better to continue. But this is trivial, IMO, so either was is ok with me. > Besides, this can be safely squashed into patch 1. Yes.