From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EFCFC433E0 for ; Mon, 15 Jun 2020 17:07:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D52B2078A for ; Mon, 15 Jun 2020 17:07:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LoGksC0K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D52B2078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jksa2-0000zk-PV; Mon, 15 Jun 2020 17:07:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jksa1-0000zY-CM for xen-devel@lists.xenproject.org; Mon, 15 Jun 2020 17:07:29 +0000 X-Inumbo-ID: b11ffa28-af2a-11ea-8496-bc764e2007e4 Received: from mail-ej1-x62f.google.com (unknown [2a00:1450:4864:20::62f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b11ffa28-af2a-11ea-8496-bc764e2007e4; Mon, 15 Jun 2020 17:07:28 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id gl26so18206499ejb.11 for ; Mon, 15 Jun 2020 10:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=hqHhgaFrlcO83k4C5b2M9JPfNRM2JDDLhQ2XRBpOHtY=; b=LoGksC0K9WNR/Us8A+tvRA79I7Ek74p0qSFd5AgCgaTWtGOEd104GftXixeiTxsrlN t1KuucguMXMqKCj42OkQM2t61M9OEABVUcVJGDiQdgmLg9BTW0+CJh5KJwS94fLiFCZF HhcyCuIDTgayDsYeCa6R3XvTPHxKfBUuQnbK3YO/hx1lZYwr9VKVe8e+iw3zKhzcKYQi rlXjzEd0OG3OaKGKdhX4D5UNOz0y2PkbXxp0yJlN7HJ+8FxEdsFG4JUZ9pjj1Wmna8oF qMYkwzfMDeqfeoX0l9UynU9pZXrlMFF9qhicoHUPzy0DWIvFqdy+DBukJ1jEruX8GUfg Oh3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=hqHhgaFrlcO83k4C5b2M9JPfNRM2JDDLhQ2XRBpOHtY=; b=Eilsit1xJoacEdjUB2EhQhsPNjlfeccIovRjUYVTwXFgd2HwxCq40nUkPEzORNZDiN g7LfIZflbvEJKiAJJbQOo/4b5FgsahFh7Xb+UDwFs2bWKVKr5DaehdlwqcMcLrYYVtVl ubX7Dkr2cZCYjnH/b3hyQM/1PpCySCSFd5ljeURRHbkLlsIOTFl8xgb2KDMEn978wvhR N9QO6fOXomLV1oshfWHQtYcZ1MliMVILSOQSIbryBBWItJ2bC7Mvmn64yUOjbmWIdo7i Z3LnQlaRXmHlDhNF3AbRIsg+VTQv4qoPSe5FZ2tNKh+p9Z2JubVVkfQC3Q6x1jyltFQ8 /w3A== X-Gm-Message-State: AOAM531wcKjxz6KDMkg3LYpmHOxzfv3jyN+6IhRCdbJ4sV/iYrStZguq tunG/YmmnoSIXGtk0j5fo8M= X-Google-Smtp-Source: ABdhPJz0w5KKIX4jtQJHwTc3CgYftxEl23fW/zTaMRUnhIoZR0mGobxmlElq+Qej0P+z9sve6aznZw== X-Received: by 2002:a17:906:f1cf:: with SMTP id gx15mr25773015ejb.207.1592240848012; Mon, 15 Jun 2020 10:07:28 -0700 (PDT) Received: from CBGR90WXYV0 (54-240-197-234.amazon.com. [54.240.197.234]) by smtp.gmail.com with ESMTPSA id w21sm9462115ejc.11.2020.06.15.10.07.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jun 2020 10:07:27 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Jan Beulich'" , "'Andrew Cooper'" References: <20200610142923.9074-1-roger.pau@citrix.com> <20200610142923.9074-3-roger.pau@citrix.com> <6de3a582-d9a8-60b5-9525-c9223932e4ed@citrix.com> <00f901d64013$6615a860$3240f920$@xen.org> <73dcc93f-3d2e-e6f0-a044-83a060bddaa4@suse.com> In-Reply-To: <73dcc93f-3d2e-e6f0-a044-83a060bddaa4@suse.com> Subject: RE: [PATCH for-4.14 v2 2/2] x86/passthrough: introduce a flag for GSIs not requiring an EOI or unmask Date: Mon, 15 Jun 2020 18:07:26 +0100 Message-ID: <003301d64337$725ba800$5712f800$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQHx2+DDRjLQssRal4XfU2f+2Pe7FQIj4hRNAekcXgMCG/MkqgGc689vqGSIHSA= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: xen-devel@lists.xenproject.org, 'Wei Liu' , 'Roger Pau Monne' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Jan Beulich > Sent: 15 June 2020 17:17 > To: paul@xen.org; 'Andrew Cooper' > Cc: 'Roger Pau Monne' ; = xen-devel@lists.xenproject.org; 'Wei Liu' > Subject: Re: [PATCH for-4.14 v2 2/2] x86/passthrough: introduce a flag = for GSIs not requiring an EOI > or unmask >=20 > On 11.06.2020 19:11, Paul Durrant wrote: > >> -----Original Message----- > >> From: Andrew Cooper > >> Sent: 11 June 2020 17:26 > >> To: Roger Pau Monne ; = xen-devel@lists.xenproject.org > >> Cc: paul@xen.org; Jan Beulich ; Wei Liu = > >> Subject: Re: [PATCH for-4.14 v2 2/2] x86/passthrough: introduce a = flag for GSIs not requiring an > EOI > >> or unmask > >> > >> On 10/06/2020 15:29, Roger Pau Monne wrote: > >>> There's no need to setup a timer for GSIs that are edge triggered, > >>> since those don't require any EIO or unmask, and hence couldn't = block > >>> other interrupts. > >>> > >>> Note this is only used by PVH dom0, that can setup the passthrough = of > >>> edge triggered interrupts from the vIO-APIC. One example of such = kind > >>> of interrupt that can be used by a PVH dom0 would be the RTC = timer. > >>> > >>> While there introduce an out label to do the unlock and reduce = code > >>> duplication. > >>> > >>> Signed-off-by: Roger Pau Monn=C3=A9 > >> > >> Acked-by: Andrew Cooper > > > > Release-acked-by: Paul Durrant >=20 > Strictly speaking these tags were too little for the patch to go > in - the change to drivers/passthrough/io.c would also have > required Paul's (or my) R-b. I take it that this was sort of > implied by the R-a-b. FAOD I have added my R-b. Paul >=20 > Jan