RE: [PATCH v5 8/8] iommu: stop calling IOMMU page tables 'p2m tables'

[Paul Durrant <xadimgnik@gmail.com>]

> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: 10 September 2020 15:27
> To: Paul Durrant <paul@xen.org>
> Cc: xen-devel@lists.xenproject.org; Paul Durrant <pdurrant@amazon.com>; Andrew Cooper
> <andrew.cooper3@citrix.com>; Kevin Tian <kevin.tian@intel.com>
> Subject: Re: [PATCH v5 8/8] iommu: stop calling IOMMU page tables 'p2m tables'
> 
> On 07.09.2020 09:40, Paul Durrant wrote:
> > --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> > +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> > @@ -491,8 +491,8 @@ static int amd_iommu_group_id(u16 seg, u8 bus, u8 devfn)
> >
> >  #include <asm/io_apic.h>
> >
> > -static void amd_dump_p2m_table_level(struct page_info* pg, int level,
> > -                                     paddr_t gpa, int indent)
> > +static void amd_dump_page_table_level(struct page_info* pg, int level,
> 
> Could you flip * and space here as you touch the line anyway?
> 

Sure.

> > @@ -504,7 +504,7 @@ static void amd_dump_p2m_table_level(struct page_info* pg, int level,
> >      table_vaddr = __map_domain_page(pg);
> >      if ( table_vaddr == NULL )
> >      {
> > -        printk("Failed to map IOMMU domain page %"PRIpaddr"\n",
> > +        printk("%s: failed to map domain page %"PRIpaddr"\n", __func__,
> >                  page_to_maddr(pg));
> 
> Why the addition of __func__? Personally I'd rather see most of its
> uses go away ... (There are two more further down.) Preferably with
> this dropped again

Ok.

> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 

Thanks.

  Paul

> Jan