From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E51FEB64DC for ; Tue, 11 Jul 2023 06:48:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7D4088638D; Tue, 11 Jul 2023 08:48:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="HHmscfBQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F04CA8618E; Tue, 11 Jul 2023 08:48:28 +0200 (CEST) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 050C4867E6 for ; Tue, 11 Jul 2023 08:48:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230711064822epoutp016064e76c2ea7e747bb8dfea5a0455600~wvWUQ2OxP2768027680epoutp017 for ; Tue, 11 Jul 2023 06:48:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230711064822epoutp016064e76c2ea7e747bb8dfea5a0455600~wvWUQ2OxP2768027680epoutp017 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1689058102; bh=0PxBEMLpsmrJ06pJkNCWaKuAEXlUoZfjLq3xGZy7hkU=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=HHmscfBQ0s1mDDf5VyWhtOene+OlAFUzw+aCSg6qqJtVSw019uWNoOaMJTfqR4YTc yXufBF4Ty2a/XRv4M+RNShPaJp9PG5kx0Y12cy6ieLP/c5kWbb7RGib+eSet+Iay7j NL5BKZbLblLuk0kkrzTFuQLw+J340zZjcb/8ocdI= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20230711064821epcas1p4dde5329544b3ab2e1a39b574eb59eccc~wvWUGOb2O2657526575epcas1p4T; Tue, 11 Jul 2023 06:48:21 +0000 (GMT) Received: from epsmgec1p1.samsung.com (unknown [182.195.36.134]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4R0WfX44NYz4x9Q7; Tue, 11 Jul 2023 06:48:20 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmgec1p1.samsung.com (Symantec Messaging Gateway) with SMTP id 18.F9.28930.43BFCA46; Tue, 11 Jul 2023 15:48:20 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230711064820epcas1p12e9ede4cb1b2d8d6af3fd437455fad5e~wvWSoOjlZ2555725557epcas1p18; Tue, 11 Jul 2023 06:48:20 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230711064820epsmtrp2c2f6d908816225db512d680734369fa7~wvWSncQxn3132031320epsmtrp2k; Tue, 11 Jul 2023 06:48:20 +0000 (GMT) X-AuditID: b6c32a36-d9bfa70000007102-6d-64acfb346b0b Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id F6.02.34491.43BFCA46; Tue, 11 Jul 2023 15:48:20 +0900 (KST) Received: from jh80chung01 (unknown [10.113.111.84]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230711064820epsmtip12e495b964152f69f4a40d828843b9488~wvWScm6F60231002310epsmtip1E; Tue, 11 Jul 2023 06:48:20 +0000 (GMT) From: "Jaehoon Chung" To: "'Michal Simek'" , , Cc: "'Ashok Reddy Soma'" , "'Peng Fan'" In-Reply-To: Subject: RE: [PATCH] mmc: zynq_sdhci: Dll reset only for ZynqMP platform Date: Tue, 11 Jul 2023 15:48:19 +0900 Message-ID: <003501d9b3c3$addb3800$0991a800$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLAX+pBizWn5UK9cKexjbvf7nHH5AGM3ITJAXjcQ7YCG1ws/a29vjfQ Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkk+LIzCtJLcpLzFFi42LZdljTQNfk95oUgxmX5C16nnlYTJ68htFi 7/GLrBY/Vn1htXi7t5PdgdWj9dJfNo+zd3Ywemx8t4PJY+/n3ywBLFHZNhmpiSmpRQqpecn5 KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAe5UUyhJzSoFCAYnFxUr6djZF +aUlqQoZ+cUltkqpBSk5BaYFesWJucWleel6eaklVoYGBkamQIUJ2RlLX3xiKugQq7jYyt3A +EWwi5GTQ0LARGLxoy3sXYxcHEICOxglVp1YyAzhfGKUmHxiCSuE841Rov/NHiaYls17L0El 9jJKfPu8H8p5ySjx628jK0gVm4CexP9FILM4OUQEwiVmzmhkAbGZBcIk1nWfBYpzcHAKWEt8 escLEhYW8JA43HoArJxFQFXi9MmrYOW8ApYSLbseMkHYghInZz6BGiMvsf3tHGaIgxQkfj5d xgqxyk1izusLUDUiErM728DekRBo5JD49raVDaLBReLrmmksELawxKvjoAAAsaUkPr/bywbR 0MwosXTJQVYIp4dR4l/DdahuY4n9SyczgXzALKApsX6XPkRYUWLn77mMEJv5JN597WEFKZEQ 4JXoaBOCKFGRuPT6JRPMrrtP/rNOYFSaheS3WUh+m4Xkh1kIyxYwsqxiFEstKM5NTy02LDCC x3Zyfu4mRnCa1DLbwTjp7Qe9Q4xMHIyHGCU4mJVEeAsOrkoR4k1JrKxKLcqPLyrNSS0+xGgK DO2JzFKiyfnARJ1XEm9oYmlgYmZkbGJhaGaoJM4753FvipBAemJJanZqakFqEUwfEwenVANT RZjcqi/HXj/eejXf/tL/WLOtOofqMjbwJZe3Taye51Lz5810x+xy82c+E12kUjxvXij4XRDq UDdfTmHHue8HgznrNj6zvvp736PvRsxaL8/MubEsSc0gdGly4jNnQflCZusfzo4n24qlp2kV 9bA2M239vznq8xzf14vUOWKcjke/eLTdxkT0zrmk7nnhz9gDetULK57aix+5o7Z8ls7/0gxt //B7fxd4il7edvX9PSGJ1H0WL/KvWzdGvfW1Mpx9juMep4OsdpkO7+zWrY9/2MZNi+DiO7Vg vfN6Qy7h0tCcd1ctgz/fWFLqenZxgdtSi8jt5e57Zz0L6ubsvqglxBV/5KxGRj37Cw3OA+xK LMUZiYZazEXFiQB0EXSXHAQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrILMWRmVeSWpSXmKPExsWy7bCSnK7J7zUpBvOO8lj0PPOwmDx5DaPF 3uMXWS1+rPrCavF2bye7A6tH66W/bB5n7+xg9Nj4bgeTx97Pv1kCWKK4bFJSczLLUov07RK4 Mpa++MRU0CFWcbGVu4Hxi2AXIyeHhICJxOa9l1i7GLk4hAR2M0pMat7CCpGQkvj8dCpbFyMH kC0scfhwMUTNc0aJ0yf+soPUsAnoSfxftJAZpEZEIFJi+4kKkDCzQJjEpdNzGCHqO5kker6A LODg4BSwlvj0jhekRljAQ+Jw6wFmEJtFQFXi9MmrLCA2r4ClRMuuh0wQtqDEyZlPWCBmakv0 PmxlhLDlJba/ncMMcaaCxM+ny8BOFhFwk5jz+gJUvYjE7M425gmMwrOQjJqFZNQsJKNmIWlZ wMiyilEytaA4Nz232LDAMC+1XK84Mbe4NC9dLzk/dxMjOFa0NHcwbl/1Qe8QIxMH4yFGCQ5m JRHegoOrUoR4UxIrq1KL8uOLSnNSiw8xSnOwKInzir/oTRESSE8sSc1OTS1ILYLJMnFwSjUw 1QlMCjAUyilIXPzlUI3T7JyS80bFhj/vJa7TO37na2m1LhtLbtaJ22UFKz6dPPgz02u7oOPc ZCmurljdzDCxhJi+9AOxuZ9ijJ7V8Wh3Gvp5XHwyq3y6kPuWrghF+4cXxWeH5hiv19l4hcOp ZiFnx5fmddPWndtevvXnjEu7v7SvyRbhDCk6bPBeTvlwQ0RshvkvRs9PGlPEGg6ai22bFW17 6cjDU99Pc5YZrpE+9mVvP2ensNAJ5w/hfMYbRLfd97AsFSm6KHsqp2DTrhc/Jtx1Lngc1PA7 pa9c5fSM7Hb59UyGgStObJI65F8rKGj+M8Sue0Lkm6t8Cw7pm03jevOv9dkmwX1d7ukxOSeU WIozEg21mIuKEwEp969LBAMAAA== X-CMS-MailID: 20230711064820epcas1p12e9ede4cb1b2d8d6af3fd437455fad5e X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230710121212epcas1p34d0fdfe9d31b8d28f2e1f167c7685eff References: <000001d9b3b4$9064a360$b12dea20$@samsung.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, > -----Original Message----- > From: Michal Simek > Sent: Tuesday, July 11, 2023 3:28 PM > To: Jaehoon Chung ; u-boot@lists.denx.de; git@xilinx.com > Cc: 'Ashok Reddy Soma' ; 'Peng Fan' > Subject: Re: [PATCH] mmc: zynq_sdhci: Dll reset only for ZynqMP platform > > Hi, > > On 7/11/23 07:00, Jaehoon Chung wrote: > > Hi, > > > >> -----Original Message----- > >> From: Michal Simek > >> Sent: Monday, July 10, 2023 9:12 PM > >> To: u-boot@lists.denx.de; git@xilinx.com > >> Cc: Ashok Reddy Soma ; Jaehoon Chung ; Peng Fan > >> > >> Subject: [PATCH] mmc: zynq_sdhci: Dll reset only for ZynqMP platform > >> > >> From: Ashok Reddy Soma > >> > >> Dll reset is needed only for ZynqMP platforms, add condition in tuning > >> to call arasan_zynqmp_dll_reset() just for ZynqMP platforms. > >> > >> On other platforms like Versal NET, If this condition is not added, we > >> see PLM error messages when dll reset smc is called. > >> > >> Signed-off-by: Ashok Reddy Soma > >> Signed-off-by: Michal Simek > >> --- > >> > >> drivers/mmc/zynq_sdhci.c | 7 +++++-- > >> 1 file changed, 5 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c > >> index e779251ce34f..935540d17194 100644 > >> --- a/drivers/mmc/zynq_sdhci.c > >> +++ b/drivers/mmc/zynq_sdhci.c > >> @@ -422,7 +422,8 @@ static int arasan_sdhci_execute_tuning(struct mmc *mmc, u8 opcode) > >> > >> mdelay(1); > >> > >> - arasan_zynqmp_dll_reset(host, priv->node_id); > >> + if (device_is_compatible(mmc->dev, "xlnx,zynqmp-8.9a")) > >> + arasan_zynqmp_dll_reset(host, priv->node_id); > > > > How about using local variable to check whether it needs to reset or not? > > It's not efficient to call device_is_compatible() everytime. > > (I'm not sure that it will be added more in future.) > > > > e.g) > > bool reset = device_is_compatible(mmc->dev, "xlx,zynmp-8.8a"); > > > > if (reset) > > arasan_zynqmp_dll_reset(host, priv->node_id); > > > > .. > > > > If (reset) > > arasan_zynqmp_dll_reset(host, priv->node_id); > > This is very valid request and TBH I have already added this to our TODO list to > convert all device_is_compatible() to flags because over time the driver was > extended and this construct is used more than it should be. > > This is going to be the last device_is_compatible() patch. > Is it fine for you? It's fine. Thanks! Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > > Thanks, > Michal > >