From: "Tobias Fiebig" <tobias@fiebig.nl>
To: "'Jason Wang'" <jasowang@redhat.com>
Cc: "'Stefan Hajnoczi'" <stefanha@redhat.com>,
<qemu-devel@nongnu.org>, <qemu-stable@nongnu.org>,
"'Russell King - ARM Linux'" <linux@armlinux.org.uk>
Subject: RE: [PATCH for-7.2] rtl8139: honor large send MSS value
Date: Wed, 16 Nov 2022 11:04:26 +0100 [thread overview]
Message-ID: <003c01d8f9a2$cffad4d0$6ff07e70$@fiebig.nl> (raw)
In-Reply-To: <CACGkMEtJ2+2yhHgD33wiWvUEREei2ThQAkRNFWzRrDt5D50u+g@mail.gmail.com>
Heho,
> Ok, I think I found at least one issue:
>
> /* large send MSS mask, bits 16...25 */
> #define CP_TC_LGSEN_MSS_MASK ((1 << 12) - 1)
>
> First, MSS occupies 11 bits from 16 to 26 Second, the mask is wrong it should be ((1 << 11) - 1)
Awesome, thanks, will give this a shot later on and let you know.
With best regards,
Tobias
next prev parent reply other threads:[~2022-11-16 10:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 16:36 [PATCH for-7.2] rtl8139: honor large send MSS value Stefan Hajnoczi
2022-11-15 23:36 ` Tobias Fiebig
2022-11-16 4:19 ` Jason Wang
2022-11-16 2:58 ` Tobias Fiebig
2022-11-16 6:54 ` Jason Wang
2022-11-16 10:04 ` Tobias Fiebig [this message]
2022-11-16 11:20 ` Tobias Fiebig
2022-11-16 15:47 ` Stefan Hajnoczi
2022-11-17 2:49 ` Tobias Fiebig
2022-11-17 11:07 ` Stefan Hajnoczi
2022-11-17 11:15 ` Stefan Hajnoczi
2022-11-17 11:26 ` Tobias Fiebig
2022-11-17 16:56 ` Stefan Hajnoczi
2022-11-17 17:02 ` Tobias Fiebig
2022-11-17 20:42 ` Tobias Fiebig
2022-11-17 22:51 ` Stefan Hajnoczi
2022-11-18 7:10 ` Jason Wang
2022-11-16 4:13 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003c01d8f9a2$cffad4d0$6ff07e70$@fiebig.nl' \
--to=tobias@fiebig.nl \
--cc=jasowang@redhat.com \
--cc=linux@armlinux.org.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.