RE: [PATCH net-next 9/9] net: txgbe: Implement SRIOV for AML devices

["Jiawen Wu" <jiawenwu@trustnetic.com>]

On Mon, May 19, 2025 11:59 PM, Simon Horman wrote:
> On Fri, May 16, 2025 at 05:32:20PM +0800, Jiawen Wu wrote:
> > Support to bring VFs link up for AML 25G/10G devices.
> 
> Hi Jiawen,
> 
> I think this warrants a bit more explanation: what is required for
> these devices; and perhaps how that differs from other devices.

For the chip design, the PHY/PCS attached AML 25G/10G devices is
different from SP devices (wx_mac_sp). And the read/write of I2C and
PHY/PCS are controlled by firmware, which is described in patch(4/9).
So the different PHYLINK mode is added for AML devices.
And for this patch, the SRIOV related function is added since the functions
.mac_link_up and .mac_link_down are changed.

> 
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> > ---
> >  drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
> > index 6bcf67bef576..7dbcf41750c1 100644
> > --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
> > +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
> > @@ -10,6 +10,7 @@
> >  #include "../libwx/wx_lib.h"
> >  #include "../libwx/wx_ptp.h"
> >  #include "../libwx/wx_hw.h"
> > +#include "../libwx/wx_sriov.h"
> >  #include "txgbe_type.h"
> >  #include "txgbe_aml.h"
> >  #include "txgbe_hw.h"
> > @@ -315,6 +316,8 @@ static void txgbe_mac_link_up_aml(struct phylink_config *config,
> >  	wx->last_rx_ptp_check = jiffies;
> >  	if (test_bit(WX_STATE_PTP_RUNNING, wx->state))
> >  		wx_ptp_reset_cyclecounter(wx);
> > +	/* ping all the active vfs to let them know we are going up */
> > +	wx_ping_all_vfs_with_link_status(wx, true);
> >  }
> >
> >  static void txgbe_mac_link_down_aml(struct phylink_config *config,
> > @@ -329,6 +332,8 @@ static void txgbe_mac_link_down_aml(struct phylink_config *config,
> >  	wx->speed = SPEED_UNKNOWN;
> >  	if (test_bit(WX_STATE_PTP_RUNNING, wx->state))
> >  		wx_ptp_reset_cyclecounter(wx);
> > +	/* ping all the active vfs to let them know we are going down */
> > +	wx_ping_all_vfs_with_link_status(wx, false);
> >  }
> >
> >  static void txgbe_mac_config_aml(struct phylink_config *config, unsigned int mode,
> > --
> > 2.48.1
> >
>