From: Vikrampal <vikram.pal@samsung.com>
To: 'Luiz Augusto von Dentz' <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org,
'Dmitry Kasatkin' <d.kasatkin@samsung.com>,
cpgs@samsung.com
Subject: RE: [PATCH 1/7] monitor: Adjust for ERTM control bytes
Date: Wed, 03 Dec 2014 12:35:44 +0530 [thread overview]
Message-ID: <003d01d00ec7$976a6f00$c63f4d00$@samsung.com> (raw)
In-Reply-To: <CABBYNZLhEKz3GQRg-NgwC=tEorV_ygV+FmR_65_r7Bx6tZzSxw@mail.gmail.com>
Hi Luiz,
> -----Original Message-----
> From: Luiz Augusto von Dentz [mailto:luiz.dentz@gmail.com]
> Sent: Friday, November 28, 2014 2:08 PM
> To: Vikrampal Yadav
> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin; cpgs@samsung.com
> Subject: Re: [PATCH 1/7] monitor: Adjust for ERTM control bytes
>
> Hi Vikram,
>
> On Fri, Nov 21, 2014 at 3:47 PM, Vikrampal Yadav
> <vikram.pal@samsung.com> wrote:
> > Adjustment for ERTM control bytes fixed.
> > ---
> > monitor/l2cap.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/monitor/l2cap.c b/monitor/l2cap.c index ebdd20f..635b967
> > 100644
> > --- a/monitor/l2cap.c
> > +++ b/monitor/l2cap.c
> > @@ -2621,6 +2621,9 @@ static void l2cap_frame(uint16_t index, bool in,
> uint16_t handle,
> > connless_packet(index, in, handle, cid, data, size);
> > break;
> > case 0x0003:
> > + /* Adjust for ERTM control bytes */
> > + data += 2;
> > + size -= 2;
> > amp_packet(index, in, handle, cid, data, size);
> > break;
> > case 0x0004:
> > --
> > 1.9.1
>
> What are those bytes, shouldn't they be printed?
These bytes are not being printed even in hcidump.
>
>
> --
> Luiz Augusto von Dentz
Regards,
Vikram
next prev parent reply other threads:[~2014-12-03 7:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 13:47 [PATCH 0/7] L2CAP control field + AVRCP browsing PDU parsing Vikrampal Yadav
2014-11-21 13:47 ` [PATCH 1/7] monitor: Adjust for ERTM control bytes Vikrampal Yadav
2014-11-28 8:37 ` Luiz Augusto von Dentz
2014-12-03 7:05 ` Vikrampal [this message]
2014-12-03 8:20 ` Luiz Augusto von Dentz
2014-11-21 13:47 ` [PATCH 2/7] monitor: Make the parameter name generic Vikrampal Yadav
2014-11-21 13:47 ` [PATCH 3/7] monitor: Add functionality to store extented control in DB Vikrampal Yadav
2014-11-21 13:47 ` [PATCH 4/7] monitor: Extract extended L2CAP extended control field Vikrampal Yadav
2014-11-21 13:47 ` [PATCH 5/7] monitor: Add support for parsing " Vikrampal Yadav
2014-11-21 13:47 ` [PATCH 6/7] monitor: Add support for parsing L2CAP " Vikrampal Yadav
2014-11-21 13:47 ` [PATCH 7/7] monitor: Add AVRCP SetBrowsedPlayer support Vikrampal Yadav
2014-11-28 8:37 ` [PATCH 0/7] L2CAP control field + AVRCP browsing PDU parsing Luiz Augusto von Dentz
2014-12-03 7:08 ` Vikrampal
2014-12-03 8:02 ` Luiz Augusto von Dentz
2014-12-03 8:57 ` Vikrampal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003d01d00ec7$976a6f00$c63f4d00$@samsung.com' \
--to=vikram.pal@samsung.com \
--cc=cpgs@samsung.com \
--cc=d.kasatkin@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.