From: chanho.min@lge.com (Chanho Min)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dma-mapping: fix potential build error under !CMA
Date: Mon, 2 Jun 2014 11:45:25 +0900 [thread overview]
Message-ID: <004101cf7e0c$b4fab3f0$1ef01bd0$@min@lge.com> (raw)
In-Reply-To: <1401673528-19077-1-git-send-email-chanho.min@lge.com>
Please ignore this patch. It was fixed on v3.15.
Sorry for the noise.
Chanho
> From: Chanho Min [mailto:chanho.min at lge.com]
> Sent: Monday, June 02, 2014 10:45 AM
> To: Russell King; Michal Nazarewicz; Marek Szyprowski
> Cc: Gioh Kim; Joonsoo Kim; HyoJun Im; linux-arm-kernel at lists.infradead.org; linux-
> kernel at vger.kernel.org; linux-arch at vger.kernel.org; Chanho Min
> Subject: [PATCH] arm: dma-mapping: fix potential build error under !CMA
>
> This patch fixes build error under !CONFIG_CMA. dev_get_cma_area can be used
> when CMA is disabled when the bellow patch is appied.
>
> "arm: dma-mapping: add checking cma area initialized"
> https://lkml.org/lkml/2014/5/22/35
>
> arch/arm/mm/dma-mapping.c: In function 'atomic_pool_init':
> arch/arm/mm/dma-mapping.c:361:2: error: implicit declaration of function
> 'dev_get_cma_area' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Chanho Min <chanho.min@lge.com>
> ---
> arch/arm/include/asm/dma-contiguous.h | 2 +-
> include/asm-generic/dma-contiguous.h | 13 +++++++++++--
> 2 files changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/include/asm/dma-contiguous.h b/arch/arm/include/asm/dma-contiguous.h
> index 3ed37b4..56c17bc 100644
> --- a/arch/arm/include/asm/dma-contiguous.h
> +++ b/arch/arm/include/asm/dma-contiguous.h
> @@ -2,11 +2,11 @@
> #define ASMARM_DMA_CONTIGUOUS_H
>
> #ifdef __KERNEL__
> -#ifdef CONFIG_CMA
>
> #include <linux/types.h>
> #include <asm-generic/dma-contiguous.h>
>
> +#ifdef CONFIG_CMA
> void dma_contiguous_early_fixup(phys_addr_t base, unsigned long size);
>
> #endif
> diff --git a/include/asm-generic/dma-contiguous.h b/include/asm-generic/dma-contiguous.h
> index 294b1e7..3d48460 100644
> --- a/include/asm-generic/dma-contiguous.h
> +++ b/include/asm-generic/dma-contiguous.h
> @@ -2,11 +2,11 @@
> #define ASM_DMA_CONTIGUOUS_H
>
> #ifdef __KERNEL__
> -#ifdef CONFIG_CMA
>
> #include <linux/device.h>
> #include <linux/dma-contiguous.h>
>
> +#ifdef CONFIG_CMA
> static inline struct cma *dev_get_cma_area(struct device *dev)
> {
> if (dev && dev->cma_area)
> @@ -22,7 +22,16 @@ static inline void dev_set_cma_area(struct device *dev, struct cma *cma)
> dma_contiguous_default_area = cma;
> }
>
> -#endif
> +#else
> +static inline struct cma *dev_get_cma_area(struct device *dev)
> +{
> + return NULL;
> +}
> +
> +static inline void dev_set_cma_area(struct device *dev, struct cma *cma)
> +{
> +}
> #endif
>
> #endif
> +#endif
> --
> 1.7.9.5
prev parent reply other threads:[~2014-06-02 2:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 1:45 [PATCH] arm: dma-mapping: fix potential build error under !CMA Chanho Min
2014-06-02 1:45 ` Chanho Min
2014-06-02 2:45 ` Chanho Min
2014-06-02 2:45 ` Chanho Min [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004101cf7e0c$b4fab3f0$1ef01bd0$@min@lge.com' \
--to=chanho.min@lge.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.