From: "Alan Raison" <alan@theraisons.me.uk>
To: "'Kevin P. Fleming'" <kpfleming@digium.com>,
"'Junio C Hamano'" <gitster@pobox.com>
Cc: <git@vger.kernel.org>
Subject: [PATCH] Corrected return values in prep_for_email;
Date: Thu, 9 Dec 2010 13:24:16 -0000 [thread overview]
Message-ID: <004201cb97a4$6127cc60$23776520$@me.uk> (raw)
In-Reply-To: <4CFE8E97.4020508@digium.com>
>From ebe98d1c682f268b39a7eaf3ef529accbf0ac61c Mon Sep 17 00:00:00 2001
From: Alan Raison <alan@theraisons.me.uk>
Date: Mon, 6 Dec 2010 15:49:21 +0000
Subject: [PATCH] Corrected return values in prep_for_email;
Function was returning 0 for failure and 1 for success which was breaking
the logic in the main loop.
Corrected to return 0 for success, 1 for failure. Function now also returns
in all cases, rather than exiting.
---
contrib/hooks/post-receive-email | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/hooks/post-receive-email
b/contrib/hooks/post-receive-email
index 85724bf..f99ea95 100755
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -144,13 +144,13 @@ prep_for_email()
short_refname=${refname##refs/remotes/}
echo >&2 "*** Push-update of tracking branch,
$refname"
echo >&2 "*** - no email generated."
- exit 0
+ return 1
;;
*)
# Anything else (is there anything else?)
echo >&2 "*** Unknown type of update to $refname
($rev_type)"
echo >&2 "*** - no email generated"
- return 0
+ return 1
;;
esac
@@ -166,10 +166,10 @@ prep_for_email()
esac
echo >&2 "*** $config_name is not set so no email will be
sent"
echo >&2 "*** for $refname update $oldrev->$newrev"
- return 0
+ return 1
fi
- return 1
+ return 0
}
#
--
1.7.3.1.msysgit.0
next prev parent reply other threads:[~2010-12-09 13:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 16:32 [PATCH] Corrected return values in post-receive-email.prep_for_email Alan Raison
2010-12-07 16:50 ` Thiago Farina
2010-12-07 17:10 ` Alan Raison
2010-12-07 19:34 ` Junio C Hamano
2010-12-07 19:44 ` Kevin P. Fleming
2010-12-09 13:24 ` Alan Raison [this message]
2010-12-09 15:19 ` [PATCH] Corrected return values in prep_for_email; Kevin P. Fleming
2010-12-09 16:03 ` Alan Raison
2010-12-09 17:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004201cb97a4$6127cc60$23776520$@me.uk' \
--to=alan@theraisons.me.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kpfleming@digium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.