All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Leon Romanovsky' <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: 'Gil Rockah' <gilr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCH] Support for Chelsio T6 devices
Date: Tue, 20 Sep 2016 09:12:13 -0500	[thread overview]
Message-ID: <004401d21348$fc2c9940$f485cbc0$@opengridcomputing.com> (raw)
In-Reply-To: <20160920102108.GG26673-2ukJVAZIZ/Y@public.gmane.org>

> > diff --git a/src/perftest_parameters.h b/src/perftest_parameters.h
> > index 448e398..727a65f 100755
> > --- a/src/perftest_parameters.h
> > +++ b/src/perftest_parameters.h
> > @@ -269,7 +269,8 @@ enum ctx_device {
> >  	CONNECTX4		= 10,
> >  	CONNECTX4LX		= 11,
> >  	QLOGIC_E4		= 12,
> > -	QLOGIC_AH		= 13
> > +	QLOGIC_AH		= 13,
> > +	CHELSIO_T6		= 14
> 
> Nit comment,
> if you use "14," and not "14", the next submitter will send patch with
> less churn.

Yup.  I usually try to adhere to the coding style of the existing code though. 



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2016-09-20 14:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19 19:55 [PATCH] Support for Chelsio T6 devices Steve Wise
     [not found] ` <20160919200957.8777AE0BC1-/5N3P9jjx0xzbRFIqnYvSA@public.gmane.org>
2016-09-20 10:21   ` Leon Romanovsky
     [not found]     ` <20160920102108.GG26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-20 14:12       ` Steve Wise [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004401d21348$fc2c9940$f485cbc0$@opengridcomputing.com' \
    --to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
    --cc=gilr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.