From mboxrd@z Thu Jan 1 00:00:00 1970 From: swise@opengridcomputing.com (Steve Wise) Date: Sat, 22 Oct 2016 10:57:28 -0500 Subject: [PATCH RFC v2 2/3] rdma_cm: add rdma_consumer_reject() helper function In-Reply-To: <20161021121428.GB17028@lst.de> References: <20161021121428.GB17028@lst.de> Message-ID: <004501d22c7c$fd3e6fa0$f7bb4ee0$@opengridcomputing.com> > > --- a/drivers/infiniband/core/cma.c > > +++ b/drivers/infiniband/core/cma.c > > @@ -114,6 +114,19 @@ const char *__attribute_const__ > rdma_reject_msg(struct rdma_cm_id *id, > > } > > EXPORT_SYMBOL(rdma_reject_msg); > > > > +bool rdma_consumer_reject(struct rdma_cm_id *id, int reason) > > +{ > > + if (rdma_ib_or_roce(id->device, id->port_num)) > > + return ib_consumer_reject(reason); > > + > > + if (rdma_protocol_iwarp(id->device, id->port_num)) > > + return iw_consumer_reject(reason); > > + > > + /* FIXME should we WARN_ONCE() here? */ > > + return false; > > Yes. Also I'd just inline the ib_consumer_reject and iw_consumer_reject > helpers here. > Why is that preferred vs the static inline functions in ib_cm.h and iw_cm.h? From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH RFC v2 2/3] rdma_cm: add rdma_consumer_reject() helper function Date: Sat, 22 Oct 2016 10:57:28 -0500 Message-ID: <004501d22c7c$fd3e6fa0$f7bb4ee0$@opengridcomputing.com> References: <20161021121428.GB17028@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161021121428.GB17028-jcswGhMUV9g@public.gmane.org> Content-Language: en-us Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Christoph Hellwig' Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, sagig-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org, axboe-b10kYP2dOMg@public.gmane.org List-Id: linux-rdma@vger.kernel.org > > --- a/drivers/infiniband/core/cma.c > > +++ b/drivers/infiniband/core/cma.c > > @@ -114,6 +114,19 @@ const char *__attribute_const__ > rdma_reject_msg(struct rdma_cm_id *id, > > } > > EXPORT_SYMBOL(rdma_reject_msg); > > > > +bool rdma_consumer_reject(struct rdma_cm_id *id, int reason) > > +{ > > + if (rdma_ib_or_roce(id->device, id->port_num)) > > + return ib_consumer_reject(reason); > > + > > + if (rdma_protocol_iwarp(id->device, id->port_num)) > > + return iw_consumer_reject(reason); > > + > > + /* FIXME should we WARN_ONCE() here? */ > > + return false; > > Yes. Also I'd just inline the ib_consumer_reject and iw_consumer_reject > helpers here. > Why is that preferred vs the static inline functions in ib_cm.h and iw_cm.h? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html