From: Manjunatha Venkatesh <manjunatha.venkatesh@nxp.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, will@kernel.org, axboe@kernel.dk,
robh+dt@kernel.org, mb@lightnvm.io,
ckeepax@opensource.cirrus.com, arnd@arndb.d, mst@redhat.com,
javier@javigon.com, mikelley@microsoft.com, jasowang@redhat.com,
sunilmut@microsoft.com, bjorn.andersson@linaro.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
ashish.deshpande@nxp.com, rvmanjumce@gmail.com
Subject: Re: [EXT] Re: [PATCH v5 2/2] misc: nxp-sr1xx: UWB driver support for sr1xx series chip
Date: Fri, 7 Oct 2022 19:49:34 +0530 [thread overview]
Message-ID: <0047b375-e7b8-a67d-82dd-112f44836bb2@nxp.com> (raw)
In-Reply-To: <YyHrT6q9fockgPjl@kroah.com>
On 9/14/2022 8:25 PM, Greg KH wrote:
> Caution: EXT Email
>
> On Wed, Sep 14, 2022 at 07:59:44PM +0530, Manjunatha Venkatesh wrote:
>> +/**
>> + * sr1xx_dev_transceive
>> + * @op_mode indicates write/read operation
>> + *
>> + * Write and Read logic implemented under same api with
>> + * mutex lock protection so write and read synchronized
>> + *
>> + * During Uwb ranging sequence(read) need to block write sequence
>> + * in order to avoid some race condition scenarios.
>> + *
>> + * Returns : Number of bytes write/read if read is success else (-1)
> I'm sure I mentioned this before, but NEVER use magic "-1" as an error
> value. Use the real in-kernel -ERROR numbers for error codes please.
> This needs to be fixed in many places in this code.
Will fix this in the next patch submission.
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2022-10-07 14:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 14:29 [PATCH v5 0/2] Uwb: Nxp: Driver for SR1XX SOCs Patch Series Manjunatha Venkatesh
2022-09-14 14:29 ` [PATCH v5 1/2] dt-bindings: uwb: Device tree information for Nxp SR1XX SOCs Manjunatha Venkatesh
2022-09-14 14:36 ` Arnd Bergmann
2022-10-07 11:39 ` [EXT] " Manjunatha Venkatesh
2022-10-07 12:30 ` Krzysztof Kozlowski
2022-09-16 19:26 ` Rob Herring
2022-09-14 14:29 ` [PATCH v5 2/2] misc: nxp-sr1xx: UWB driver support for sr1xx series chip Manjunatha Venkatesh
2022-09-14 14:53 ` Greg KH
2022-11-30 3:40 ` [EXT] " Manjunatha Venkatesh
2022-11-30 7:27 ` Greg KH
2022-12-20 14:09 ` Manjunatha Venkatesh
2022-12-20 14:30 ` Greg KH
2022-12-20 14:43 ` Manjunatha Venkatesh
2022-09-14 14:55 ` Greg KH
2022-10-07 14:19 ` Manjunatha Venkatesh [this message]
2022-09-14 15:09 ` Arnd Bergmann
[not found] ` <cd397721-f549-5c65-2c65-35b09c3ea7f9@nxp.com>
2022-10-07 14:11 ` [EXT] " Arnd Bergmann
2022-11-30 3:55 ` Manjunatha Venkatesh
2022-10-07 14:57 ` Greg Kroah-Hartman
2022-11-30 4:09 ` Manjunatha Venkatesh
2022-11-30 7:23 ` Greg Kroah-Hartman
2022-12-20 14:33 ` Manjunatha Venkatesh
2022-12-20 14:51 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0047b375-e7b8-a67d-82dd-112f44836bb2@nxp.com \
--to=manjunatha.venkatesh@nxp.com \
--cc=arnd@arndb.d \
--cc=ashish.deshpande@nxp.com \
--cc=axboe@kernel.dk \
--cc=bjorn.andersson@linaro.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=javier@javigon.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
--cc=mikelley@microsoft.com \
--cc=mst@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rvmanjumce@gmail.com \
--cc=sunilmut@microsoft.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.