From: "Martin Eriksson" <nitrax@giron.wox.org>
To: <ivangurdiev@yahoo.com>
Cc: "LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Via-rhine minor issues
Date: Sun, 21 Apr 2002 12:00:35 +0200 [thread overview]
Message-ID: <004b01c1e91b$61f52890$0201a8c0@homer> (raw)
In-Reply-To: <02042101022001.00833@cobra.linux>
----- Original Message -----
From: "Ivan G." <ivangurdiev@yahoo.com>
To: "Urban Widmark" <urban@teststation.com>; "Shing Chuang"
<ShingChuang@via.com.tw>
Cc: "LKML" <linux-kernel@vger.kernel.org>
Sent: Sunday, April 21, 2002 9:02 AM
Subject: [PATCH] Via-rhine minor issues
> Please comment on this before I send to Marcello.
> I am a newbie and would like some help.
> Patch fixes minor issues in the driver.
>
> Note: Shing Chuang, this includes your own patch for Rhine-III support
> since it's not yet in the kernel and I diff-ed against the original
source,
> while I added your patch to my driver version.
>
> BTW your own patch wouldn't patch cleanly for some reason.
>
> DIFF-ED AGAINST:
> 2.4.19-pre3 ( I don't think there were changes to via-rhine
> b-ween pre3 and pre7)
>
> CONTENTS:
> - Shing Chuang's Rhine III support and 6100 cleanup patch.
> - edited comments on supported cards
> - removed unused W_MAX_TIMEOUT
> - added flag HasDavicomPhy for VT86C100A card
> - changed chip_id in wait_for_reset as parameter since np is not
initialized
> the first time this function is called (should this be fixed differently?)
> - enable all interrupts (add 4 additional ones)
> - fix debug message - frame is off by one
> - change "Something Wicked" message to "PCI Error" (I still don't see the
> purpose of the trap)
I don't think "PCI Error" is such a great message.. sounds too serious.
What about "Unhandled <something>"?
_____________________________________________________
| Martin Eriksson <nitrax@giron.wox.org>
| MSc CSE student, department of Computing Science
| Umeå University, Sweden
next prev parent reply other threads:[~2002-04-21 10:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-21 7:02 [PATCH] Via-rhine minor issues Ivan G.
2002-04-21 10:00 ` Martin Eriksson [this message]
2002-04-21 10:19 ` Urban Widmark
2002-04-21 16:07 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2002-04-21 21:16 Ivan G.
2002-04-21 23:02 ` your mail Jeff Garzik
2002-04-21 23:25 ` [PATCH] Via-rhine minor issues Ivan G.
2002-04-22 19:33 ` Urban Widmark
2002-04-23 4:07 ` Ivan G.
2002-04-23 13:44 ` Urban Widmark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004b01c1e91b$61f52890$0201a8c0@homer' \
--to=nitrax@giron.wox.org \
--cc=ivangurdiev@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.