From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Fedin Subject: RE: [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Date: Thu, 05 Nov 2015 14:14:19 +0300 Message-ID: <004f01d117bb$1e4fbb40$5aef31c0$@samsung.com> References: <4568ad982f0af1846994119961cbb798edff311c.1446542020.git.p.fedin@samsung.com> <5639C1A5.1040708@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <5639C1A5.1040708-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Content-language: ru Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Krzysztof Kozlowski' , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: 'Rob Herring' , 'Pawel Moll' , 'Mark Rutland' , 'Ian Campbell' , 'Kumar Gala' , 'Kukjin Kim' List-Id: linux-samsung-soc@vger.kernel.org Hello! > > + ethernet@3 { > > + compatible = "smsc,lan9115"; > > + reg = <3 0 0x10000>; > > + phy-mode = "mii"; > > + interrupt-parent = <&gpx0>; > > + interrupts = <5 8>; > > s/8/IRQ_TYPE_LEVEL_LOW/ > (is this really level low interrupt?) Yes, according to: https://github.com/AndreiLux/Perseus-S3/blob/master/arch/arm/mach-exynos/mach-smdk5250.c#L133 > Some other DTS include regulators: vddvario-supply and vdd33a-supply. It > seems that they are not described in SMSC911x bindings but in > GPMC-eth... but the smsc911x driver is requesting them. Could you > investigate that? I think these regulators should be provided (and > SMSC911x bindings should be updated). Sorry, i cannot. The board has lots of jumpers, which choose between fixed voltage and regulators for different components, according to board's manual, but the manual is very poor IMHO, and i don't understand how to use them. And i use default, fixed-voltage configuration. One of my colleagues tried to get it working, but failed. It actually requires more time, and IIRC you need to bring up i2c before you can drive regulators. So can we leave it as it is for now? At least it works, and this is much better than no ethernet support at all. > I don't have the board schematics so I couldn't verify the GPIOs. Me neither, i wrote GPIO settings according to chip datasheet i have. They are actually chip-specific, but i wrote them in board file because on different boards you may use different banks, and therefore different pins. Or, if you don't use SROMc at all, you can configure all pins to do something else. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: p.fedin@samsung.com (Pavel Fedin) Date: Thu, 05 Nov 2015 14:14:19 +0300 Subject: [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410 In-Reply-To: <5639C1A5.1040708@samsung.com> References: <4568ad982f0af1846994119961cbb798edff311c.1446542020.git.p.fedin@samsung.com> <5639C1A5.1040708@samsung.com> Message-ID: <004f01d117bb$1e4fbb40$5aef31c0$@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello! > > + ethernet at 3 { > > + compatible = "smsc,lan9115"; > > + reg = <3 0 0x10000>; > > + phy-mode = "mii"; > > + interrupt-parent = <&gpx0>; > > + interrupts = <5 8>; > > s/8/IRQ_TYPE_LEVEL_LOW/ > (is this really level low interrupt?) Yes, according to: https://github.com/AndreiLux/Perseus-S3/blob/master/arch/arm/mach-exynos/mach-smdk5250.c#L133 > Some other DTS include regulators: vddvario-supply and vdd33a-supply. It > seems that they are not described in SMSC911x bindings but in > GPMC-eth... but the smsc911x driver is requesting them. Could you > investigate that? I think these regulators should be provided (and > SMSC911x bindings should be updated). Sorry, i cannot. The board has lots of jumpers, which choose between fixed voltage and regulators for different components, according to board's manual, but the manual is very poor IMHO, and i don't understand how to use them. And i use default, fixed-voltage configuration. One of my colleagues tried to get it working, but failed. It actually requires more time, and IIRC you need to bring up i2c before you can drive regulators. So can we leave it as it is for now? At least it works, and this is much better than no ethernet support at all. > I don't have the board schematics so I couldn't verify the GPIOs. Me neither, i wrote GPIO settings according to chip datasheet i have. They are actually chip-specific, but i wrote them in board file because on different boards you may use different banks, and therefore different pins. Or, if you don't use SROMc at all, you can configure all pins to do something else. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032196AbbKELOZ (ORCPT ); Thu, 5 Nov 2015 06:14:25 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:56071 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031125AbbKELOX (ORCPT ); Thu, 5 Nov 2015 06:14:23 -0500 X-AuditID: cbfec7f5-f794b6d000001495-08-563b3a0c267d From: Pavel Fedin To: "'Krzysztof Kozlowski'" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "'Rob Herring'" , "'Pawel Moll'" , "'Mark Rutland'" , "'Ian Campbell'" , "'Kumar Gala'" , "'Kukjin Kim'" References: <4568ad982f0af1846994119961cbb798edff311c.1446542020.git.p.fedin@samsung.com> <5639C1A5.1040708@samsung.com> In-reply-to: <5639C1A5.1040708@samsung.com> Subject: RE: [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Date: Thu, 05 Nov 2015 14:14:19 +0300 Message-id: <004f01d117bb$1e4fbb40$5aef31c0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQInd0NHxwReN7LBFLXzkPqpXKHCoQHcQWVDAgq4v9mdwUsTQA== Content-language: ru X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsVy+t/xy7o8VtZhBo8Oa1nMP3KO1aL/zUJW i3OvVjJavH5haNH/+DWzxabH11gtLu+aw2Yx4/w+Joul1y8yWUyYvpbFonXvEXYHbo8189Yw elzu62XyWLn8C5vHplWdbB6bl9R79G1ZxejxeZNcAHsUl01Kak5mWWqRvl0CV8bbydPYCg7z Vsw8/Jy5gfETVxcjJ4eEgInEwYYbrBC2mMSFe+vZuhi5OIQEljJKPF56igXC+c4osXzWRiaQ KjYBdYnTXz+AJUQEdjFK/NrSDeYwC7xhlDi17DEzRMtyRomP3/+AtXAKaEvsuTSdEcQWFnCW ONm7AizOIqAqcercEmYQm1fAUuLw0gUsELagxI/J98BsZgEtifU7jzNB2PISm9e8ZYY4VkFi x9nXQDM5gM5wkrj8TA6iRERi2r97zBMYhWYhmTQLyaRZSCbNQtKygJFlFaNoamlyQXFSeq6R XnFibnFpXrpecn7uJkZIrH3dwbj0mNUhRgEORiUeXoNqqzAh1sSy4srcQ4wSHMxKIrxSstZh QrwpiZVVqUX58UWlOanFhxilOViUxHln7nofIiSQnliSmp2aWpBaBJNl4uCUamDsW2wv83Bq te+iHAHTarZpF5XqP03aKHHww/fiZ4unPwgxs7D6lVRy9MbH4+/9uVo7AzbvsNb9sGOPbb98 mUtfV7JYK4vdkfoTR3y+Rwvf17ogs3CR/+dVW7bc6+q4UnFHW2/KhkkVP82Fpu3rZtbRnSgz S0twAt+rdnFvFwZTgxcn3yYfSHmqxFKckWioxVxUnAgAjx+C+7ECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! > > + ethernet@3 { > > + compatible = "smsc,lan9115"; > > + reg = <3 0 0x10000>; > > + phy-mode = "mii"; > > + interrupt-parent = <&gpx0>; > > + interrupts = <5 8>; > > s/8/IRQ_TYPE_LEVEL_LOW/ > (is this really level low interrupt?) Yes, according to: https://github.com/AndreiLux/Perseus-S3/blob/master/arch/arm/mach-exynos/mach-smdk5250.c#L133 > Some other DTS include regulators: vddvario-supply and vdd33a-supply. It > seems that they are not described in SMSC911x bindings but in > GPMC-eth... but the smsc911x driver is requesting them. Could you > investigate that? I think these regulators should be provided (and > SMSC911x bindings should be updated). Sorry, i cannot. The board has lots of jumpers, which choose between fixed voltage and regulators for different components, according to board's manual, but the manual is very poor IMHO, and i don't understand how to use them. And i use default, fixed-voltage configuration. One of my colleagues tried to get it working, but failed. It actually requires more time, and IIRC you need to bring up i2c before you can drive regulators. So can we leave it as it is for now? At least it works, and this is much better than no ethernet support at all. > I don't have the board schematics so I couldn't verify the GPIOs. Me neither, i wrote GPIO settings according to chip datasheet i have. They are actually chip-specific, but i wrote them in board file because on different boards you may use different banks, and therefore different pins. Or, if you don't use SROMc at all, you can configure all pins to do something else. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia