From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout4.samsung.com ([203.254.224.34]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UZbVx-0004MN-FX for linux-mtd@lists.infradead.org; Tue, 07 May 2013 06:36:42 +0000 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMF006XZ10E1LE0@mailout4.samsung.com> for linux-mtd@lists.infradead.org; Tue, 07 May 2013 15:36:19 +0900 (KST) From: Jingoo Han To: 'Artem Bityutskiy' Subject: [PATCH 14/26] mtd: nand: fsmc_nand: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 15:36:18 +0900 Message-id: <005201ce4aed$2e797760$8b6c6620$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: ko Cc: 'Vipin Kumar' , linux-mtd@lists.infradead.org, Jingoo Han , 'David Woodhouse' List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/mtd/nand/fsmc_nand.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c index 911e243..ca7fd0c 100644 --- a/drivers/mtd/nand/fsmc_nand.c +++ b/drivers/mtd/nand/fsmc_nand.c @@ -1174,8 +1174,6 @@ static int fsmc_nand_remove(struct platform_device *pdev) { struct fsmc_nand_data *host = platform_get_drvdata(pdev); - platform_set_drvdata(pdev, NULL); - if (host) { nand_release(&host->mtd); -- 1.7.2.5