From: "Ravinandan Arakali" <ravinandan.arakali@neterion.com>
To: "'Brian Haley'" <brian.haley@hp.com>, <netdev@vger.kernel.org>
Cc: <jgarzik@pobox.com>,
"Ananda. Raju \(E-mail\)" <ananda.raju@neterion.com>,
"Leonid. Grossman \(E-mail\)" <leonid.grossman@neterion.com>
Subject: RE: [PATCH] s2io: netpoll support
Date: Tue, 13 Jun 2006 16:33:10 -0700 [thread overview]
Message-ID: <005401c68f41$bc4bfaa0$3e10100a@pc.s2io.com> (raw)
In-Reply-To: <448849F6.8050002@hp.com>
I don't think we should disable and enable all interrupts in the
poll_controller entry point. With the current patch, at the end of
the routine _all_ interrupts get enabled which is not desirable.
Maybe you should just do disable_irq() at start of function and
enable_irq() before exiting, the way some of the other drivers do.
Ravi
-----Original Message-----
From: netdev-owner@vger.kernel.org
[mailto:netdev-owner@vger.kernel.org]On Behalf Of Brian Haley
Sent: Thursday, June 08, 2006 9:02 AM
To: netdev@vger.kernel.org
Cc: jgarzik@pobox.com
Subject: [PATCH] s2io: netpoll support
This adds netpoll support for things like netconsole/kgdboe to the s2io
10GbE driver.
This duplicates some code from s2io_poll() as I wanted to be
least-invasive, someone from Neterion might have other thoughts?
Signed-off-by: Brian Haley <brian.haley@hp.com>
next prev parent reply other threads:[~2006-06-13 23:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-08 16:01 [PATCH] s2io: netpoll support Brian Haley
2006-06-13 23:33 ` Ravinandan Arakali [this message]
2006-06-15 18:36 ` Brian Haley
2006-06-22 19:45 ` Ravinandan Arakali
2006-06-26 16:33 ` Brian Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005401c68f41$bc4bfaa0$3e10100a@pc.s2io.com' \
--to=ravinandan.arakali@neterion.com \
--cc=ananda.raju@neterion.com \
--cc=brian.haley@hp.com \
--cc=jgarzik@pobox.com \
--cc=leonid.grossman@neterion.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.