From: Pavel Fedin <p.fedin@samsung.com>
To: 'Eric Blake' <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: 'Paolo Bonzini' <pbonzini@redhat.com>,
'Eduardo Habkost' <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] backends/hostmem-file: Add file-name property
Date: Tue, 27 Oct 2015 17:51:17 +0300 [thread overview]
Message-ID: <005401d110c6$efdea550$cf9beff0$@samsung.com> (raw)
In-Reply-To: <562F8C40.1030707@redhat.com>
Hello!
> Is there a missing qapi change, so that the new filename attribute can
> also be specified by QMP command? Or do we not support hotplug of
> ivshmem yet?
To tell the truth, i don't know, and we currently do not test ivshmem with hotplug here, neither i heard that we would want it. And i actually even don't know how hotplug works in qemu.
I discovered an issue and fixed it - this simple. Without this fix ivshmem + hostmem-file is unusable because the file cannot be located, therefore the memory cannot be shared.
Could this (possibly) missing thing be added afterwards, if necessary? Anyway, my fix does not break anything (i hope).
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-10-27 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 13:53 [Qemu-devel] [PATCH] backends/hostmem-file: Add file-name property Pavel Fedin
2015-10-27 14:37 ` Eric Blake
2015-10-27 14:51 ` Pavel Fedin [this message]
2015-10-27 14:58 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005401d110c6$efdea550$cf9beff0$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.